Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Side by Side Diff: src/arm64/assembler-arm64-inl.h

Issue 967323002: Refactor BreakLocationIterator. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: static_cast instead Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/arm64/assembler-arm64.cc ('k') | src/arm64/debug-arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_ARM64_ASSEMBLER_ARM64_INL_H_ 5 #ifndef V8_ARM64_ASSEMBLER_ARM64_INL_H_
6 #define V8_ARM64_ASSEMBLER_ARM64_INL_H_ 6 #define V8_ARM64_ASSEMBLER_ARM64_INL_H_
7 7
8 #include "src/arm64/assembler-arm64.h" 8 #include "src/arm64/assembler-arm64.h"
9 #include "src/assembler.h" 9 #include "src/assembler.h"
10 #include "src/debug.h" 10 #include "src/debug.h"
(...skipping 820 matching lines...) Expand 10 before | Expand all | Expand 10 after
831 IsRuntimeEntry(rmode_) || 831 IsRuntimeEntry(rmode_) ||
832 IsExternalReference(rmode_)); 832 IsExternalReference(rmode_));
833 Assembler::set_target_address_at(pc_, host_, NULL); 833 Assembler::set_target_address_at(pc_, host_, NULL);
834 } 834 }
835 835
836 836
837 bool RelocInfo::IsPatchedReturnSequence() { 837 bool RelocInfo::IsPatchedReturnSequence() {
838 // The sequence must be: 838 // The sequence must be:
839 // ldr ip0, [pc, #offset] 839 // ldr ip0, [pc, #offset]
840 // blr ip0 840 // blr ip0
841 // See arm64/debug-arm64.cc BreakLocationIterator::SetDebugBreakAtReturn(). 841 // See arm64/debug-arm64.cc BreakLocation::SetDebugBreakAtReturn().
842 Instruction* i1 = reinterpret_cast<Instruction*>(pc_); 842 Instruction* i1 = reinterpret_cast<Instruction*>(pc_);
843 Instruction* i2 = i1->following(); 843 Instruction* i2 = i1->following();
844 return i1->IsLdrLiteralX() && (i1->Rt() == ip0.code()) && 844 return i1->IsLdrLiteralX() && (i1->Rt() == ip0.code()) &&
845 i2->IsBranchAndLinkToRegister() && (i2->Rn() == ip0.code()); 845 i2->IsBranchAndLinkToRegister() && (i2->Rn() == ip0.code());
846 } 846 }
847 847
848 848
849 bool RelocInfo::IsPatchedDebugBreakSlotSequence() { 849 bool RelocInfo::IsPatchedDebugBreakSlotSequence() {
850 Instruction* current_instr = reinterpret_cast<Instruction*>(pc_); 850 Instruction* current_instr = reinterpret_cast<Instruction*>(pc_);
851 return !current_instr->IsNop(Assembler::DEBUG_BREAK_NOP); 851 return !current_instr->IsNop(Assembler::DEBUG_BREAK_NOP);
(...skipping 411 matching lines...) Expand 10 before | Expand all | Expand 10 after
1263 1263
1264 1264
1265 void Assembler::ClearRecordedAstId() { 1265 void Assembler::ClearRecordedAstId() {
1266 recorded_ast_id_ = TypeFeedbackId::None(); 1266 recorded_ast_id_ = TypeFeedbackId::None();
1267 } 1267 }
1268 1268
1269 1269
1270 } } // namespace v8::internal 1270 } } // namespace v8::internal
1271 1271
1272 #endif // V8_ARM64_ASSEMBLER_ARM64_INL_H_ 1272 #endif // V8_ARM64_ASSEMBLER_ARM64_INL_H_
OLDNEW
« no previous file with comments | « src/arm64/assembler-arm64.cc ('k') | src/arm64/debug-arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698