src/ic/ic-state.cc - Issue 967243002: Polish Maybe API a bit, removing useless creativity and fixing some signatures.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ic/ic-state.cc

Issue 967243002: Polish Maybe API a bit, removing useless creativity and fixing some signatures. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Simplified friendship. Added check in FromJust. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/ic/ic-state.cc

diff --git a/src/ic/ic-state.cc b/src/ic/ic-state.cc

index a38a27a34a291686a596ab0c5272e504e4c0ef52..1c9b7fee23e0cd0537d6e89ad97ea8afb2c5bb68 100644

--- a/src/ic/ic-state.cc

+++ b/src/ic/ic-state.cc

@@ -45,7 +45,7 @@ STATIC_CONST_MEMBER_DEFINITION const int BinaryOpICState::LAST_TOKEN;

BinaryOpICState::BinaryOpICState(Isolate* isolate, ExtraICState extra_ic_state)

- : isolate_(isolate) {

+ : fixed_right_arg_(Nothing<int>()), isolate_(isolate) {

op_ =

static_cast<Token::Value>(FIRST_TOKEN + OpField::decode(extra_ic_state));

fixed_right_arg_ =

« include/v8.h ('K') | « src/ic/ic-state.h ('k') | src/objects.cc » ('j') | no next file with comments »