Source/web/WebAXObject.cpp - Issue 967213004: Removed FrameView's windowToContents and contentsToWindow methods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebAXObject.cpp

Issue 967213004: Removed FrameView's windowToContents and contentsToWindow methods. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/WebAXObject.cpp

diff --git a/Source/web/WebAXObject.cpp b/Source/web/WebAXObject.cpp

index 7ecd32b604c71ad398837355dc3b7c955a42d894..d0456d32902df96ca99bc3a0d6a520bf312776ad 100644

--- a/Source/web/WebAXObject.cpp

+++ b/Source/web/WebAXObject.cpp

@@ -701,7 +701,8 @@ WebAXObject WebAXObject::hitTest(const WebPoint& point) const

if (isDetached())

return WebAXObject();

- IntPoint contentsPoint = m_private->documentFrameView()->windowToContents(point);

+ // FIXME: point looks like it may be in viewport coordinates (at least sometimes).

+ IntPoint contentsPoint = m_private->documentFrameView()->rootFrameToContents(point);

RefPtr<AXObject> hit = m_private->accessibilityHitTest(contentsPoint);

if (hit)

« Source/core/frame/PinchViewport.cpp ('K') | « Source/web/ValidationMessageClientImpl.cpp ('k') | Source/web/WebFrameWidgetImpl.cpp » ('j') | Source/web/tests/PinchViewportTest.cpp » ('J')