Source/web/ChromeClientImpl.cpp - Issue 967213004: Removed FrameView's windowToContents and contentsToWindow methods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/ChromeClientImpl.cpp

Issue 967213004: Removed FrameView's windowToContents and contentsToWindow methods. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/ChromeClientImpl.cpp

diff --git a/Source/web/ChromeClientImpl.cpp b/Source/web/ChromeClientImpl.cpp

index 16f5b8fdb8bd0030f0705de2479ee80d3e005e29..7738f546dcec735fddc9630469fd835e39e18853 100644

--- a/Source/web/ChromeClientImpl.cpp

+++ b/Source/web/ChromeClientImpl.cpp

@@ -838,10 +838,10 @@ void ChromeClientImpl::showImeIfNeeded()

m_webView->client()->showImeIfNeeded();

}

-void ChromeClientImpl::showUnhandledTapUIIfNeeded(IntPoint tappedPosition, Node* tappedNode, bool pageChanged)

+void ChromeClientImpl::showUnhandledTapUIIfNeeded(IntPoint tappedPositionInViewport, Node* tappedNode, bool pageChanged)

{

if (m_webView->client())

- m_webView->client()->showUnhandledTapUIIfNeeded(WebPoint(tappedPosition), WebNode(tappedNode), pageChanged);

+ m_webView->client()->showUnhandledTapUIIfNeeded(WebPoint(tappedPositionInViewport), WebNode(tappedNode), pageChanged);

}

void ChromeClientImpl::handleKeyboardEventOnTextField(HTMLInputElement& inputElement, KeyboardEvent& event)

« Source/core/frame/PinchViewport.cpp ('K') | « Source/core/testing/Internals.cpp ('k') | Source/web/ContextMenuClientImpl.cpp » ('j') | Source/web/tests/PinchViewportTest.cpp » ('J')