Source/core/inspector/InspectorDOMAgent.cpp - Issue 967213004: Removed FrameView's windowToContents and contentsToWindow methods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/inspector/InspectorDOMAgent.cpp

Issue 967213004: Removed FrameView's windowToContents and contentsToWindow methods. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/frame/PinchViewport.cpp ('K') | « Source/core/html/forms/ColorInputType.cpp ('k') | Source/core/layout/LayerScrollableArea.cpp » ('j') | Source/web/tests/PinchViewportTest.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/inspector/InspectorDOMAgent.cpp

diff --git a/Source/core/inspector/InspectorDOMAgent.cpp b/Source/core/inspector/InspectorDOMAgent.cpp

index 78356fdee2c6bf522f764cb628e47159fbf3f0ca..7f1a6087a97a5882b1ab97cd5e4fa516b4bcab3c 100644

--- a/Source/core/inspector/InspectorDOMAgent.cpp

+++ b/Source/core/inspector/InspectorDOMAgent.cpp

@@ -151,13 +151,13 @@ static bool parseQuad(const RefPtr<JSONArray>& quadArray, FloatQuad* quad)

return true;

}

-static Node* hoveredNodeForPoint(LocalFrame* frame, const IntPoint& point, bool ignorePointerEventsNone)

+static Node* hoveredNodeForPoint(LocalFrame* frame, const IntPoint& pointInRootFrame, bool ignorePointerEventsNone)

{

HitTestRequest::HitTestRequestType hitType = HitTestRequest::Move | HitTestRequest::ReadOnly | HitTestRequest::AllowChildFrameContent;

if (ignorePointerEventsNone)

hitType |= HitTestRequest::IgnorePointerEventsNone;

HitTestRequest request(hitType);

- HitTestResult result(frame->view()->windowToContents(point));

+ HitTestResult result(frame->view()->rootFrameToContents(pointInRootFrame));

frame->contentRenderer()->hitTest(request, result);

Node* node = result.innerPossiblyPseudoNode();

while (node && node->nodeType() == Node::TEXT_NODE)