Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(697)

Unified Diff: Source/core/frame/SmartClip.h

Issue 967213004: Removed FrameView's windowToContents and contentsToWindow methods. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/frame/PinchViewport.cpp ('k') | Source/core/frame/SmartClip.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/frame/SmartClip.h
diff --git a/Source/core/frame/SmartClip.h b/Source/core/frame/SmartClip.h
index 8523b4982e15e01c10cb8a6dd921494d5b7998cd..38308ed23644bc5172fab04c84d34b8de11decf8 100644
--- a/Source/core/frame/SmartClip.h
+++ b/Source/core/frame/SmartClip.h
@@ -46,17 +46,17 @@ public:
SmartClipData(Node* node, IntRect rect, String string)
: m_isEmpty(!node)
- , m_rect(rect)
+ , m_rectInViewport(rect)
, m_string(string)
{
}
- IntRect rect() const;
+ IntRect rectInViewport() const;
const String& clipData() const;
private:
bool m_isEmpty;
- IntRect m_rect;
+ IntRect m_rectInViewport;
String m_string;
};
@@ -76,10 +76,9 @@ private:
float pageScaleFactor();
Node* minNodeContainsNodes(Node* minNode, Node* newNode);
- Node* findBestOverlappingNode(Node*, const IntRect& cropRect);
+ Node* findBestOverlappingNode(Node*, const IntRect& cropRectInViewport);
bool shouldSkipBackgroundImage(Node*);
- void collectOverlappingChildNodes(Node* parentNode, const IntRect& cropRect, WillBeHeapVector<RawPtrWillBeMember<Node>>& overlappingNodeInfoTable);
- IntRect convertRectToWindow(const IntRect& nodeRect);
+ void collectOverlappingChildNodes(Node* parentNode, const IntRect& cropRectInViewport, WillBeHeapVector<RawPtrWillBeMember<Node>>& overlappingNodeInfoTable);
String extractTextFromNode(Node*);
RefPtrWillBeMember<LocalFrame> m_frame;
« no previous file with comments | « Source/core/frame/PinchViewport.cpp ('k') | Source/core/frame/SmartClip.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698