Source/core/html/forms/ColorInputType.cpp - Issue 967213004: Removed FrameView's windowToContents and contentsToWindow methods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/forms/ColorInputType.cpp

Issue 967213004: Removed FrameView's windowToContents and contentsToWindow methods. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Addressed rbyers@ feedback (minus tests) Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/forms/ColorInputType.cpp

diff --git a/Source/core/html/forms/ColorInputType.cpp b/Source/core/html/forms/ColorInputType.cpp

index e821cfc071e52e1ee55120f80f05e9b7f7e1429b..f96c5d12494f2e834f62480317474ab992a402eb 100644

--- a/Source/core/html/forms/ColorInputType.cpp

+++ b/Source/core/html/forms/ColorInputType.cpp

@@ -238,7 +238,7 @@ Element& ColorInputType::ownerElement() const

IntRect ColorInputType::elementRectRelativeToViewport() const

{

- return element().document().view()->contentsToWindow(element().pixelSnappedBoundingBox());

+ return element().document().view()->contentsToViewport(element().pixelSnappedBoundingBox());

}

Color ColorInputType::currentColor()

« Source/core/frame/FrameView.h ('K') | « Source/core/frame/SmartClip.cpp ('k') | Source/core/inspector/InspectorDOMAgent.cpp » ('j') | no next file with comments »