Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Side by Side Diff: Source/web/LinkHighlight.cpp

Issue 967213004: Removed FrameView's windowToContents and contentsToWindow methods. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/web/ExternalPopupMenu.cpp ('k') | Source/web/PopupContainer.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 122 matching lines...) Expand 10 before | Expand all | Expand 10 after
133 for (unsigned i = 0; i < 4; ++i) { 133 for (unsigned i = 0; i < 4; ++i) {
134 IntPoint point; 134 IntPoint point;
135 switch (i) { 135 switch (i) {
136 case 0: point = roundedIntPoint(targetSpaceQuad.p1()); break; 136 case 0: point = roundedIntPoint(targetSpaceQuad.p1()); break;
137 case 1: point = roundedIntPoint(targetSpaceQuad.p2()); break; 137 case 1: point = roundedIntPoint(targetSpaceQuad.p2()); break;
138 case 2: point = roundedIntPoint(targetSpaceQuad.p3()); break; 138 case 2: point = roundedIntPoint(targetSpaceQuad.p3()); break;
139 case 3: point = roundedIntPoint(targetSpaceQuad.p4()); break; 139 case 3: point = roundedIntPoint(targetSpaceQuad.p4()); break;
140 } 140 }
141 141
142 // FIXME: this does not need to be absolute, just in the paint invalidat ion container's space. 142 // FIXME: this does not need to be absolute, just in the paint invalidat ion container's space.
143 point = targetRenderer->frame()->view()->contentsToWindow(point); 143 point = targetRenderer->frame()->view()->contentsToRootFrame(point);
144 point = paintInvalidationContainer->frame()->view()->windowToContents(po int); 144 point = paintInvalidationContainer->frame()->view()->rootFrameToContents (point);
145 FloatPoint floatPoint = paintInvalidationContainer->absoluteToLocal(poin t, UseTransforms); 145 FloatPoint floatPoint = paintInvalidationContainer->absoluteToLocal(poin t, UseTransforms);
146 DeprecatedPaintLayer::mapPointToPaintBackingCoordinates(paintInvalidatio nContainer, floatPoint); 146 DeprecatedPaintLayer::mapPointToPaintBackingCoordinates(paintInvalidatio nContainer, floatPoint);
147 147
148 switch (i) { 148 switch (i) {
149 case 0: compositedSpaceQuad.setP1(floatPoint); break; 149 case 0: compositedSpaceQuad.setP1(floatPoint); break;
150 case 1: compositedSpaceQuad.setP2(floatPoint); break; 150 case 1: compositedSpaceQuad.setP2(floatPoint); break;
151 case 2: compositedSpaceQuad.setP3(floatPoint); break; 151 case 2: compositedSpaceQuad.setP3(floatPoint); break;
152 case 3: compositedSpaceQuad.setP4(floatPoint); break; 152 case 3: compositedSpaceQuad.setP4(floatPoint); break;
153 } 153 }
154 } 154 }
(...skipping 200 matching lines...) Expand 10 before | Expand all | Expand 10 after
355 // Make sure we update geometry on the next callback from WebViewImpl::layou t(). 355 // Make sure we update geometry on the next callback from WebViewImpl::layou t().
356 m_geometryNeedsUpdate = true; 356 m_geometryNeedsUpdate = true;
357 } 357 }
358 358
359 WebLayer* LinkHighlight::layer() 359 WebLayer* LinkHighlight::layer()
360 { 360 {
361 return clipLayer(); 361 return clipLayer();
362 } 362 }
363 363
364 } // namespace blink 364 } // namespace blink
OLDNEW
« no previous file with comments | « Source/web/ExternalPopupMenu.cpp ('k') | Source/web/PopupContainer.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698