Credential saving clank infobar for Smart Lock.

chrome/android/java/src/org/chromium/chrome/browser/infobar/SavePasswordInfoBar.java

Index: chrome/android/java/src/org/chromium/chrome/browser/infobar/SavePasswordInfoBar.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/infobar/SavePasswordInfoBar.java b/chrome/android/java/src/org/chromium/chrome/browser/infobar/SavePasswordInfoBar.java
new file mode 100644
index 0000000000000000000000000000000000000000..0cd37b64e196291c6eb5cfe095c73873e0dcf028
--- /dev/null
+++ b/chrome/android/java/src/org/chromium/chrome/browser/infobar/SavePasswordInfoBar.java
@@ -0,0 +1,39 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+package org.chromium.chrome.browser.infobar;
+
+import org.chromium.base.CalledByNative;
+import org.chromium.chrome.browser.ResourceId;
+
+/**
+ * Save password infobar offers a user an ability to save password to the site.

[Bernhard Bauer, 2015/03/02 10:28:09]

Nit: "*The* Save Password infobars offers *the* user *the* ability to save *a*
password to the site" (or maybe "a site password").

[gone, 2015/03/02 17:39:38]

offer, for the site?

[melandory, 2015/03/03 11:55:46]

Done.

[melandory, 2015/03/03 11:55:46]

Done.

+ * Appearance and behaviour of infobar buttons depends on from where infobar was
+ * triggered.
+ */
+public class SavePasswordInfoBar extends ConfirmInfoBar {
+
+    boolean mAddMoreButton;

[Bernhard Bauer, 2015/03/02 10:28:09]

Member variables should be private. Also, you could make it final.

[gone, 2015/03/02 17:39:38]

Can you rename this boolean?  It makes it sound like the field is for an "Add
More" button (because Button is an android class).  Maybe mIsMoreButtonNeeded?

[melandory, 2015/03/03 11:55:46]

Done.

[melandory, 2015/03/03 11:55:46]

Done.

+
+    @CalledByNative
+    private static InfoBar show(long nativeInfoBar, int enumeratedIconId, String message,
+            String primaryButtonText, String secondaryButtonText, boolean addMoreButton) {
+        return new SavePasswordInfoBar(nativeInfoBar, ResourceId.mapToDrawableId(enumeratedIconId),
+                message, primaryButtonText, secondaryButtonText, addMoreButton);
+    }
+
+    SavePasswordInfoBar(long nativeInfoBar, int iconDrawbleId, String message,

[Bernhard Bauer, 2015/03/02 10:28:09]

Is this constructor meant to be called from somewhere else? If so, make it
public. If not, make it private.

[gone, 2015/03/02 17:39:38]

Should be private; you don't want people to be able to create one of these
without a native counterpart.

[melandory, 2015/03/03 11:55:46]

Done.

[melandory, 2015/03/03 11:55:46]

Done.

+            String primaryButtonText, String secondaryButtonText, boolean addMoreButton) {
+        super(nativeInfoBar, null, iconDrawbleId, null, message, null, primaryButtonText,
+                secondaryButtonText);
+        mAddMoreButton = addMoreButton;
+    }
+
+    @Override
+    public void createContent(InfoBarLayout layout) {
+        super.createContent(layout);
+        if (mAddMoreButton)

[Bernhard Bauer, 2015/03/02 10:28:09]

Android style is to either put everything on one line if it fits, or use braces.

[melandory, 2015/03/03 11:55:46]

Done.

+            layout.setCustomViewInButtonRow(OverflowSelector.createOverflowSelector(getContext()));
+    }
+}