Credential saving clank infobar for Smart Lock.

chrome/browser/ui/android/infobars/save_password_infobar.h

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_UI_ANDROID_INFOBARS_SAVE_PASSWORD_INFOBAR_H_
+#define CHROME_BROWSER_UI_ANDROID_INFOBARS_SAVE_PASSWORD_INFOBAR_H_
+
+#include "chrome/browser/password_manager/save_password_infobar_delegate.h"
+#include "chrome/browser/ui/android/infobars/confirm_infobar.h"
+
+// The Android infobar that offers the user the ability to save a password
+// for the site.
+class SavePasswordInfoBar : public ConfirmInfoBar {
+ public:
+  explicit SavePasswordInfoBar(
+      scoped_ptr<SavePasswordInfoBarDelegate> delegate);
+
+  ~SavePasswordInfoBar() override;
+
+ // Internal use: must be public to be called from base_jni_registrar.cc
+ bool RegisterSavePasswordInfoBar(JNIEnv* env);

[Bernhard Bauer, 2015/03/03 16:54:20]

I think this should be static? And it's still called nowhere. Did you test that
this doesn't crash?

[melandory, 2015/03/05 17:15:13]

It should be static. It doesn't crash and I think it's because method isn't
called anywhere.

[gone, 2015/03/05 18:23:41]

The reason why it would crash it because it _wasn't_ called anywhere.  This
method (and the other ones like it in the other C++ <-> Java linked classes)
links the C++ SavePasswordInfoBar with the Java SavePasswordInfoBar methods,
creating a mapping that allows C++ methods to be called from Java and vice
versa.  If you fail to register the methods in chrome_jni_registrar.cc, then
trying to call any methods across the language boundary will immediately result
in Chrome crashing because it can't find the methods.

That said: please remove the comment above it.  Not sure how useful it is.

+
+ private:
+  // ConfirmInfoBar:
+  base::android::ScopedJavaLocalRef<jobject> CreateRenderInfoBar(
+      JNIEnv* env) override;
+
+  scoped_ptr<SavePasswordInfoBarDelegate> save_password_delegate_;
+
+  DISALLOW_COPY_AND_ASSIGN(SavePasswordInfoBar);
+};
+
+
+#endif  // CHROME_BROWSER_UI_ANDROID_INFOBARS_SAVE_PASSWORD_INFOBAR_H_