Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Side by Side Diff: chrome/browser/password_manager/save_password_infobar_delegate.h

Issue 967193002: Credential saving clank infobar for Smart Lock. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@reusable_more_button
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_PASSWORD_MANAGER_SAVE_PASSWORD_INFOBAR_DELEGATE_H_ 5 #ifndef CHROME_BROWSER_PASSWORD_MANAGER_SAVE_PASSWORD_INFOBAR_DELEGATE_H_
6 #define CHROME_BROWSER_PASSWORD_MANAGER_SAVE_PASSWORD_INFOBAR_DELEGATE_H_ 6 #define CHROME_BROWSER_PASSWORD_MANAGER_SAVE_PASSWORD_INFOBAR_DELEGATE_H_
7 7
8 #include "base/basictypes.h" 8 #include "base/basictypes.h"
9 #include "base/compiler_specific.h"
10 #include "base/memory/scoped_ptr.h" 9 #include "base/memory/scoped_ptr.h"
11 #include "base/timer/elapsed_timer.h" 10 #include "base/timer/elapsed_timer.h"
12 #include "components/infobars/core/confirm_infobar_delegate.h" 11 #include "components/infobars/core/confirm_infobar_delegate.h"
13 #include "components/infobars/core/infobar_delegate.h"
14 #include "components/password_manager/core/browser/password_form_manager.h" 12 #include "components/password_manager/core/browser/password_form_manager.h"
15 #include "components/password_manager/core/browser/password_manager_metrics_util .h" 13 #include "components/password_manager/core/browser/password_manager_metrics_util .h"
16 14
17 namespace content { 15 namespace content {
18 class WebContents; 16 class WebContents;
19 } 17 }
20 18
19 namespace password_manager {
20 enum class CredentialSourceType;
21 }
22
21 // After a successful *new* login attempt, we take the PasswordFormManager in 23 // After a successful *new* login attempt, we take the PasswordFormManager in
22 // provisional_save_manager_ and move it to a SavePasswordInfoBarDelegate while 24 // provisional_save_manager_ and move it to a SavePasswordInfoBarDelegate while
23 // the user makes up their mind with the "save password" infobar. Note if the 25 // the user makes up their mind with the "save password" infobar. Note if the
24 // login is one we already know about, the end of the line is 26 // login is one we already know about, the end of the line is
25 // provisional_save_manager_ because we just update it on success and so such 27 // provisional_save_manager_ because we just update it on success and so such
26 // forms never end up in an infobar. 28 // forms never end up in an infobar.
27 class SavePasswordInfoBarDelegate : public ConfirmInfoBarDelegate { 29 class SavePasswordInfoBarDelegate : public ConfirmInfoBarDelegate {
28 public: 30 public:
29 // If we won't be showing the one-click signin infobar, creates a save 31 // If we won't be showing the one-click signin infobar, creates a save
30 // password infobar and delegate and adds the infobar to the InfoBarService 32 // password infobar and delegate and adds the infobar to the InfoBarService
31 // for |web_contents|. |uma_histogram_suffix| is empty, or one of the 33 // for |web_contents|. |uma_histogram_suffix| is empty, or one of the
32 // "group_X" suffixes used in the histogram names for infobar usage reporting; 34 // "group_X" suffixes used in the histogram names for infobar usage reporting;
33 // if empty, the usage is not reported, otherwise the suffix is used to choose 35 // if empty, the usage is not reported, otherwise the suffix is used to choose
34 // the right histogram. 36 // the right histogram.
35 static void Create( 37 static void Create(
36 content::WebContents* web_contents, 38 content::WebContents* web_contents,
37 scoped_ptr<password_manager::PasswordFormManager> form_to_save, 39 scoped_ptr<password_manager::PasswordFormManager> form_to_save,
38 const std::string& uma_histogram_suffix); 40 const std::string& uma_histogram_suffix,
39 41 password_manager::CredentialSourceType source_type);
40 private:
41 SavePasswordInfoBarDelegate(
42 scoped_ptr<password_manager::PasswordFormManager> form_to_save,
43 const std::string& uma_histogram_suffix);
44 42
45 ~SavePasswordInfoBarDelegate() override; 43 ~SavePasswordInfoBarDelegate() override;
46 44
45 // If the infobar was triggered by the Credential management API, then on
46 // Android
47 // it should display the "More" button.
Bernhard Bauer 2015/03/03 16:54:20 Merge this with the previous line.
melandory 2015/03/05 17:15:12 Done.
48 bool ShouldShowMoreButton();
49
47 // ConfirmInfoBarDelegate: 50 // ConfirmInfoBarDelegate:
48 Type GetInfoBarType() const override; 51 Type GetInfoBarType() const override;
49 InfoBarAutomationType GetInfoBarAutomationType() const override; 52 InfoBarAutomationType GetInfoBarAutomationType() const override;
50 int GetIconID() const override; 53 int GetIconID() const override;
51 bool ShouldExpire(const NavigationDetails& details) const override; 54 bool ShouldExpire(const NavigationDetails& details) const override;
52 void InfoBarDismissed() override; 55 void InfoBarDismissed() override;
53 base::string16 GetMessageText() const override; 56 base::string16 GetMessageText() const override;
54 base::string16 GetButtonLabel(InfoBarButton button) const override; 57 base::string16 GetButtonLabel(InfoBarButton button) const override;
55 bool Accept() override; 58 bool Accept() override;
56 bool Cancel() override; 59 bool Cancel() override;
57 60
61 private:
62 SavePasswordInfoBarDelegate(
63 scoped_ptr<password_manager::PasswordFormManager> form_to_save,
64 const std::string& uma_histogram_suffix,
65 password_manager::CredentialSourceType source_type);
66
58 // The PasswordFormManager managing the form we're asking the user about, 67 // The PasswordFormManager managing the form we're asking the user about,
59 // and should update as per her decision. 68 // and should update as per her decision.
60 scoped_ptr<password_manager::PasswordFormManager> form_to_save_; 69 scoped_ptr<password_manager::PasswordFormManager> form_to_save_;
61 70
62 // Used to track the results we get from the info bar. 71 // Used to track the results we get from the info bar.
63 password_manager::metrics_util::ResponseType infobar_response_; 72 password_manager::metrics_util::ResponseType infobar_response_;
64 73
65 // Measures the "Save password?" prompt lifetime. Used to report an UMA 74 // Measures the "Save password?" prompt lifetime. Used to report an UMA
66 // signal. 75 // signal.
67 base::ElapsedTimer timer_; 76 base::ElapsedTimer timer_;
68 77
69 // The group name corresponding to the domain name of |form_to_save_| if the 78 // The group name corresponding to the domain name of |form_to_save_| if the
70 // form is on a monitored domain. Otherwise, an empty string. 79 // form is on a monitored domain. Otherwise, an empty string.
71 const std::string uma_histogram_suffix_; 80 const std::string uma_histogram_suffix_;
72 81
82 // Records source from where infobar was triggered.
83 // Infobar appearance (title, buttons) depends on value of this parameter.
84 password_manager::CredentialSourceType source_type_;
85
73 DISALLOW_COPY_AND_ASSIGN(SavePasswordInfoBarDelegate); 86 DISALLOW_COPY_AND_ASSIGN(SavePasswordInfoBarDelegate);
74 }; 87 };
75 88
76 #endif // CHROME_BROWSER_PASSWORD_MANAGER_SAVE_PASSWORD_INFOBAR_DELEGATE_H_ 89 #endif // CHROME_BROWSER_PASSWORD_MANAGER_SAVE_PASSWORD_INFOBAR_DELEGATE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698