Credential saving clank infobar for Smart Lock.

chrome/browser/password_manager/chrome_password_manager_client.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/password_manager/chrome_password_manager_client.h"
 
 #include "base/bind_helpers.h"
 #include "base/command_line.h"
 #include "base/memory/singleton.h"
 #include "base/metrics/histogram.h"
@@ skipping 171 matching lines @@
     ManagePasswordsUIController* manage_passwords_ui_controller =
         ManagePasswordsUIController::FromWebContents(web_contents());
     manage_passwords_ui_controller->OnPasswordSubmitted(form_to_save.Pass());
   } else {
     // TODO(melandory): If type is CREDENTIAL_SOURCE_API then new bubble should
     // be shown.
     std::string uma_histogram_suffix(
         password_manager::metrics_util::GroupIdToString(
             password_manager::metrics_util::MonitoredDomainGroupId(
                 form_to_save->realm(), GetPrefs())));
-    SavePasswordInfoBarDelegate::Create(
-        web_contents(), form_to_save.Pass(), uma_histogram_suffix);
+    SavePasswordInfoBarDelegate::Create(web_contents(), form_to_save.Pass(),

[gone, 2015/03/02 17:39:38]

nit: if the arguments don't fit, c++ style puts them on their own lines IIRC

[melandory, 2015/03/03 11:55:46]

I was also surprised when I saw how clang format formatted this line, but
apparently it's allowed:
http://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Function_Decl...
see second example.

I'll put all arguments on separate line.

[Bernhard Bauer, 2015/03/03 16:54:20]

Yeah, the "either all arguments on one line, or each on a separate line" rule
only applies to method headers.

+                                        uma_histogram_suffix, type);
   }
   return true;
 }
 
 bool ChromePasswordManagerClient::PromptUserToChooseCredentials(
     ScopedVector<autofill::PasswordForm> local_forms,
     ScopedVector<autofill::PasswordForm> federated_forms,
     const GURL& origin,
     base::Callback<void(const password_manager::CredentialInfo&)> callback) {
   return ManagePasswordsUIController::FromWebContents(web_contents())->
@@ skipping 349 matching lines @@
       autofill_sync_state_ = DISALLOW_SYNC_CREDENTIALS;
   } else {
     // Allow by default.
     autofill_sync_state_ = ALLOW_SYNC_CREDENTIALS;
   }
 }
 
 const GURL& ChromePasswordManagerClient::GetMainFrameURL() const {
   return web_contents()->GetVisibleURL();
 }