Revert 237900 "Add use_goma for GYP_DEFINES"

Revert 237900 "Add use_goma for GYP_DEFINES"

Broke the blink android build.
TBR=mkwst@chromium.org

> Add use_goma for GYP_DEFINES
> 
> If use_goma is specified in GYP_DEFINES, gomacc is automatically set as
> CC wrapper and CXX wrapper.  It uses the default goma directory if the gomadir
> option is not given.  No need to fix PATH when running ninja (or make).
> This is the revival of https://codereview.chromium.org/12419003/,
> and expected to work with https://codereview.chromium.org/66303010/.
> Note: Goma team suggest not to put gomadir in PATH if you use use_goma option.
> 
> Currently, this works well with ninja (default build system of chromium).
> It does not work well with make in some case (e.g. build on linux with make).
> 
> According to the review comment, ANDROID_GOMA_WRAPPER has already been
> obsoleted.  ANDROID_GOMA_WRAPPER will be just ignored after this change.
> 
> Example 1
> $ GYP_DEFINES="clang=1 use_goma=1" build/gyp_chromium
> (no need to set CC/CXX at this stage)
> 
> build.ninja will have
> cc = ${HOME}/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang
> cxx = ${HOME}/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++
> 
> The user can run ninja without setting PATH or so.
> $ ninja -C out/Release -j100
> 
> Example 2
> 
> $ GYP_DEFINES="use_goma=1 gomadir=/path/to/goma" build/gyp_chromium
> 
> build.ninja will have
> cc = /path/to/goma/gomacc gcc
> cxx = /path/to/goma/gomacc g++
> 
> user can run ninja without setting PATH or so.
> $ ninja -C out/Release -j100
> 
> BUG=173686
> 
> Review URL: https://codereview.chromium.org/69293004

TBR=yyanagisawa@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=237911

[eae, 2013-11-29 09:55:04]

Committed patchset #1 manually as r237911.

[Yoshisato Yanagisawa, 2013-11-29 10:56:14]

lgtm

Sorry for the change.  The patch seems to have some conflicts of variables.

[eae, 2013-11-29 11:04:34]

Sorry I had to roll it back :(

I really liked the change but sadly our android bots did not.

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Yoshisato Yanagisawa, 2013-11-29 11:14:08]

That's OK.  Thank you for your comment.
GOMA_DIR behavior looks slightly strange with r237900.  GOMA_DIR given by env.
seems to be ignored after this.

Let me fix it and try again.

[eae, 2013-11-29 11:14:58]

Thanks, let me know if there is anything I can do to help.

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Yoshisato Yanagisawa, 2013-11-29 13:15:07]

ANDROID_GOMA_DIR has gone in the r237900.  However, it seems to be used in
android scripts.  I let it back and uploaded the new change:
https://codereview.chromium.org/96923002/

Will you run this on the bot (or similar bot) that showed error on r237900?

Thank you in advance.

[Nico, 2013-11-29 22:51:47]

Do you have a link to the broken build on the broken bot?

[Yoshisato Yanagisawa, 2013-12-02 01:35:14]

On 2013/11/29 22:51:47, Nico wrote:
> Do you have a link to the broken build on the broken bot?

http://build.chromium.org/p/chromium.webkit/builders/Android%20Builder/builds...

[Yoshisato Yanagisawa, 2013-12-02 01:48:25]

On 2013/12/02 01:35:14, yanagisawa wrote:
> On 2013/11/29 22:51:47, Nico wrote:
> > Do you have a link to the broken build on the broken bot?
> 
>
http://build.chromium.org/p/chromium.webkit/builders/Android%2520Builder/buil...

I have mistaken to copy it. sorry.
http://build.chromium.org/p/chromium.webkit/builders/Android%20Builder/builds...

[Yoshisato Yanagisawa, 2013-12-03 02:15:53]

On 2013/12/02 01:48:25, yanagisawa wrote:
> On 2013/12/02 01:35:14, yanagisawa wrote:
> > On 2013/11/29 22:51:47, Nico wrote:
> > > Do you have a link to the broken build on the broken bot?
> > 
> >
>
http://build.chromium.org/p/chromium.webkit/builders/Android%252520Builder/bu...
> 
> I have mistaken to copy it. sorry.
>
http://build.chromium.org/p/chromium.webkit/builders/Android%2520Builder/buil...

This page seems to automatically convert %20 to %2520 :(

I do not know it can generate correct link but URL is:
http://build.chromium.org/p/chromium.webkit/builders/Android
Builder/builds/30621