Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 966983003: Delete all uses of SpeechManager from the app list start page. (Closed)

Created:
5 years, 9 months ago by Anand Mistry (off Chromium)
Modified:
5 years, 9 months ago
Reviewers:
calamity
CC:
chromium-reviews, arv+watch_chromium.org, cychiang, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Delete all uses of SpeechManager from the app list start page. Constructing the SpeechManager creates a WebAudio instance which creates an audio output stream that prevents ChromeOS from suspending. This code is supposed to be dead and is slated for removal. This change gets rid of the usage and is intended to be mergable into the M42 branch. BUG=450081 Committed: https://crrev.com/c329228bc8fdba3d907a0735dc1a916083cdb7b5 Cr-Commit-Position: refs/heads/master@{#318969}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Delete speech_manager.js include. #

Patch Set 3 : Remove tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -66 lines) Patch
M chrome/browser/resources/app_list/start_page.js View 1 7 chunks +0 lines, -11 lines 0 comments Download
M chrome/browser/ui/webui/app_list/start_page_browsertest.js View 1 2 1 chunk +0 lines, -55 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
Anand Mistry (off Chromium)
cychiang: FYI.
5 years, 9 months ago (2015-03-03 07:02:16 UTC) #2
calamity
lgtm. Any idea when this will all get cleaned up for good? https://codereview.chromium.org/966983003/diff/1/chrome/browser/resources/app_list/start_page.js File chrome/browser/resources/app_list/start_page.js ...
5 years, 9 months ago (2015-03-03 07:15:58 UTC) #3
Anand Mistry (off Chromium)
My plan for cleaning all of this up was once M41 goes stable. I was ...
5 years, 9 months ago (2015-03-03 07:23:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/966983003/20001
5 years, 9 months ago (2015-03-03 07:24:15 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/31684)
5 years, 9 months ago (2015-03-03 11:01:35 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/966983003/40001
5 years, 9 months ago (2015-03-03 23:28:22 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-04 00:06:11 UTC) #13
commit-bot: I haz the power
5 years, 9 months ago (2015-03-04 00:06:54 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/c329228bc8fdba3d907a0735dc1a916083cdb7b5
Cr-Commit-Position: refs/heads/master@{#318969}

Powered by Google App Engine
This is Rietveld 408576698