chrome/browser/ui/browser.cc - Issue 966983002: downloads: clicking "remove" on chrome://downloads should also hide shelf item.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/browser.cc

Issue 966983002: downloads: clicking "remove" on chrome://downloads should also hide shelf item. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: slimmer Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/download/download_ui_controller.cc ('K') | « chrome/browser/download/download_ui_controller.cc ('k') | chrome/browser/ui/cocoa/download/download_item_mac.mm » ('j') | chrome/browser/ui/cocoa/download/download_item_mac.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/browser.cc

diff --git a/chrome/browser/ui/browser.cc b/chrome/browser/ui/browser.cc

index 53dfccd6dffaa85ee85a49c9146305cb6e6385c5..1dc929def70be03362a112f602aee8a5c5ab5526 100644

--- a/chrome/browser/ui/browser.cc

+++ b/chrome/browser/ui/browser.cc

@@ -1339,8 +1339,7 @@ void Browser::ShowDownload(content::DownloadItem* download) {

return;

// GetDownloadShelf creates the download shelf if it was not yet created.

- DownloadShelf* shelf = window()->GetDownloadShelf();

- shelf->AddDownload(download);

+ window()->GetDownloadShelf()->AddDownload(download);

Dan Beam 2015/03/02 18:50:09 shaves a line, didn't really see the point to crea

}

///////////////////////////////////////////////////////////////////////////////