downloads: clicking "remove" on chrome://downloads should also hide shelf item.

chrome/browser/ui/views/download/download_item_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/download/download_item_view.h"
 
 #include <algorithm>
 #include <vector>
 
 #include "base/bind.h"
@@ skipping 264 matching lines @@
   DCHECK_EQ(download(), download_item);
 
   if (IsShowingWarningDialog() && !model_.IsDangerous()) {
     // We have been approved.
     ClearWarningDialog();
   } else if (!IsShowingWarningDialog() && model_.IsDangerous()) {
     ShowWarningDialog();
     // Force the shelf to layout again as our size has changed.
     shelf_->Layout();
     SchedulePaint();
+  } else if (!model_.ShouldShowInShelf()) {
+    shelf_->RemoveDownloadView(this);
+    return;

[Dan Beam, 2015/03/02 18:50:09]

can move this earlier if this tickles the "return inside if/else" rule

[asanka, 2015/03/02 21:49:33]

Yeah. For the reasons I mentioned in .mm above. Let's exit as early as possible
if the download was removed.

[Dan Beam, 2015/03/02 22:04:07]

Done.

   } else {
     base::string16 status_text = model_.GetStatusText();
     switch (download()->GetState()) {
       case DownloadItem::IN_PROGRESS:
         download()->IsPaused() ?
             StopDownloadProgress() : StartDownloadProgress();
         LoadIconIfItemPathChanged();
         break;
       case DownloadItem::INTERRUPTED:
         StopDownloadProgress();
@@ skipping 1097 matching lines @@
 void DownloadItemView::AnimateStateTransition(State from, State to,
                                               gfx::SlideAnimation* animation) {
   if (from == NORMAL && to == HOT) {
     animation->Show();
   } else if (from == HOT && to == NORMAL) {
     animation->Hide();
   } else if (from != to) {
     animation->Reset((to == HOT) ? 1.0 : 0.0);
   }
 }