downloads: clicking "remove" on chrome://downloads should also hide shelf item.

chrome/browser/ui/cocoa/download/download_item_mac.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/cocoa/download/download_item_mac.h"
 
 #include "base/bind.h"
 #include "base/callback.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/download/download_item_model.h"
@@ skipping 24 matching lines @@
     [item_controller_ clearDangerousMode];
   }
 
   if (download->GetTargetFilePath() != lastFilePath_) {
     LoadIcon();
     lastFilePath_ = download->GetTargetFilePath();
 
     [item_controller_ updateToolTip];
   }
 
+  if (!download_model_.ShouldShowInShelf()) {

[asanka, 2015/03/02 21:49:33]

Nit: shall we move this to the top? If this condition is true, then the work
done above this would also not be necessary.

[Dan Beam, 2015/03/02 22:04:07]

Done.

+    [item_controller_ remove];  // We're deleted now!
+    return;
+  }
+
   switch (download->GetState()) {
     case DownloadItem::COMPLETE:
       if (download_model_.ShouldRemoveFromShelfWhenComplete()) {
         [item_controller_ remove];  // We're deleted now!
         return;
       }
       // fall through
     case DownloadItem::IN_PROGRESS:
     case DownloadItem::CANCELLED:
       [item_controller_ setStateFromDownload:&download_model_];
@@ skipping 36 matching lines @@
                          base::Bind(&DownloadItemMac::OnExtractIconComplete,
                                     base::Unretained(this)),
                          &cancelable_task_tracker_);
 }
 
 void DownloadItemMac::OnExtractIconComplete(gfx::Image* icon) {
   if (!icon)
     return;
   [item_controller_ setIcon:icon->ToNSImage()];
 }