downloads: clicking "remove" on chrome://downloads should also hide shelf item.

chrome/browser/download/download_ui_controller.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_DOWNLOAD_DOWNLOAD_UI_CONTROLLER_H_
 #define CHROME_BROWSER_DOWNLOAD_DOWNLOAD_UI_CONTROLLER_H_
 
 #include <set>
 
 #include "base/memory/scoped_ptr.h"
 #include "chrome/browser/download/all_download_item_notifier.h"
 
 // This class handles the task of observing a single DownloadManager for
 // notifying the UI when a new download should be displayed in the UI.
-// It invokes the OnNewDownloadReady() method of hte Delegate when the
-// target path is available for a new download.
 class DownloadUIController : public AllDownloadItemNotifier::Observer {
  public:
-  // The delegate is responsible for figuring out how to notify the UI.
-  class Delegate {
-   public:
-    virtual ~Delegate();
-
-    // This method is invoked to notify the UI of the new download |item|. Note
-    // that |item| may be in any state by the time this method is invoked.
-    virtual void OnNewDownloadReady(content::DownloadItem* item) = 0;
-  };
-
-  // |manager| is the download manager to observe for new downloads. If
-  // |delegate.get()| is NULL, then the default delegate is constructed.
-  //
-  // On Android the default delegate notifies DownloadControllerAndroid. On
-  // other platforms the target of the notification is a Browser object.
-  //
-  // Currently explicit delegates are only used for testing.
-  DownloadUIController(content::DownloadManager* manager,
-                       scoped_ptr<Delegate> delegate);

[Dan Beam, 2015/02/28 04:46:04]

I can do this cleanup separately, but I couldn't find anywhere that |delegate|
was ever used...

[Dan Beam, 2015/02/28 07:10:27]

nvm, used in tests. stupid codesearch.

[Dan Beam, 2015/03/02 18:50:09]

restored, ptal

+  // |manager| is the download manager to observe for new downloads.
+  explicit DownloadUIController(content::DownloadManager* manager);
 
   ~DownloadUIController() override;
 
  private:
   void OnDownloadCreated(content::DownloadManager* manager,
                          content::DownloadItem* item) override;
   void OnDownloadUpdated(content::DownloadManager* manager,
                          content::DownloadItem* item) override;
 
   AllDownloadItemNotifier download_notifier_;
 
-  scoped_ptr<Delegate> delegate_;
-
   DISALLOW_COPY_AND_ASSIGN(DownloadUIController);
 };
 
 #endif  // CHROME_BROWSER_DOWNLOAD_DOWNLOAD_UI_CONTROLLER_H_