Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Side by Side Diff: chrome/browser/ui/cocoa/download/download_shelf_mac.mm

Issue 966983002: downloads: clicking "remove" on chrome://downloads should also hide shelf item. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/cocoa/download/download_shelf_mac.h" 5 #include "chrome/browser/ui/cocoa/download/download_shelf_mac.h"
6 6
7 #include "chrome/browser/download/download_item_model.h" 7 #include "chrome/browser/download/download_item_model.h"
8 #include "chrome/browser/ui/browser.h" 8 #include "chrome/browser/ui/browser.h"
9 #import "chrome/browser/ui/cocoa/download/download_shelf_controller.h" 9 #import "chrome/browser/ui/cocoa/download/download_shelf_controller.h"
10 #include "chrome/browser/ui/cocoa/download/download_item_mac.h" 10 #include "chrome/browser/ui/cocoa/download/download_item_mac.h"
11 11
12 DownloadShelfMac::DownloadShelfMac(Browser* browser, 12 DownloadShelfMac::DownloadShelfMac(Browser* browser,
13 DownloadShelfController* controller) 13 DownloadShelfController* controller)
14 : browser_(browser), 14 : browser_(browser),
15 shelf_controller_(controller) { 15 shelf_controller_(controller) {
16 } 16 }
17 17
18 void DownloadShelfMac::DoAddDownload(content::DownloadItem* download) { 18 void DownloadShelfMac::DoAddDownload(content::DownloadItem* download) {
19 [shelf_controller_ addDownloadItem:download]; 19 [shelf_controller_ addDownloadItem:download];
20 } 20 }
21 21
22 void DownloadShelfMac::RemoveDownload(content::DownloadItem* download) {
23 [shelf_controller_ removeDownloadItem:download];
24 }
25
22 bool DownloadShelfMac::IsShowing() const { 26 bool DownloadShelfMac::IsShowing() const {
23 return [shelf_controller_ isVisible] == YES; 27 return [shelf_controller_ isVisible] == YES;
24 } 28 }
25 29
26 bool DownloadShelfMac::IsClosing() const { 30 bool DownloadShelfMac::IsClosing() const {
27 // TODO(estade): This is never called. For now just return false. 31 // TODO(estade): This is never called. For now just return false.
28 return false; 32 return false;
29 } 33 }
30 34
31 void DownloadShelfMac::DoShow() { 35 void DownloadShelfMac::DoShow() {
32 [shelf_controller_ showDownloadShelf:YES 36 [shelf_controller_ showDownloadShelf:YES
33 isUserAction:NO]; 37 isUserAction:NO];
34 browser_->UpdateDownloadShelfVisibility(true); 38 browser_->UpdateDownloadShelfVisibility(true);
35 } 39 }
36 40
37 void DownloadShelfMac::DoClose(CloseReason reason) { 41 void DownloadShelfMac::DoClose(CloseReason reason) {
38 [shelf_controller_ showDownloadShelf:NO 42 [shelf_controller_ showDownloadShelf:NO
39 isUserAction:reason == USER_ACTION]; 43 isUserAction:reason == USER_ACTION];
40 browser_->UpdateDownloadShelfVisibility(false); 44 browser_->UpdateDownloadShelfVisibility(false);
41 } 45 }
42 46
43 Browser* DownloadShelfMac::browser() const { 47 Browser* DownloadShelfMac::browser() const {
44 return browser_; 48 return browser_;
45 } 49 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698