On windows, build zlib as a static library.

On windows, build zlib as a static library.

Partially in preparation for building libpng on Windows.

Also, this makes us consistent across platforms for PDF.

Uses the version of zlib checked into the Chromium tree.

Remove miniz, which is replaced by zlib.

Committed: https://skia.googlesource.com/skia/+/3da9181cd52259102685f3faae68eca5ad1bf773

[scroggo, 2015-02-27 23:08:56]

scroggo@google.com changed reviewers:
+ halcanary@google.com, mtklein@google.com

[mtklein, 2015-02-27 23:31:02]

lgtm

https://codereview.chromium.org/966963002/diff/40001/gyp/zlib.gyp
File gyp/zlib.gyp (right):

https://codereview.chromium.org/966963002/diff/40001/gyp/zlib.gyp#newcode10
gyp/zlib.gyp:10: 'target_name' : 'zlib_x86_simd',
Are there portable options for these?  I'm thinking ahead to older non-Windows
x86 compilers, and of course nacl, arm, and mips.

https://codereview.chromium.org/966963002/diff/40001/gyp/zlib.gyp#newcode36
gyp/zlib.gyp:36: [ 'skia_os not in ["mac", "ios", "win"]',{
If we're going to be building zlib, I'd feel more comfortable if we could use
our homebrewed version on as many platforms as possible.  Finding bugs on one
platform will help find bugs elsewhere, and it'll just generally make our output
more consistent.

I'm also okay with landing this as-is and tearing down the Windows-only
restrictions in a follow-up.

[scroggo, 2015-03-02 14:16:16]

https://codereview.chromium.org/966963002/diff/40001/gyp/zlib.gyp
File gyp/zlib.gyp (right):

https://codereview.chromium.org/966963002/diff/40001/gyp/zlib.gyp#newcode10
gyp/zlib.gyp:10: 'target_name' : 'zlib_x86_simd',
On 2015/02/27 23:31:02, mtklein wrote:
> Are there portable options for these?  I'm thinking ahead to older non-Windows
> x86 compilers, and of course nacl, arm, and mips.

IIUC, the portable versions are in the files where they are used. For example,
see
https://chromium.googlesource.com/chromium/src/third_party/zlib/+/master/defl...
fill_window.

https://codereview.chromium.org/966963002/diff/40001/gyp/zlib.gyp#newcode36
gyp/zlib.gyp:36: [ 'skia_os not in ["mac", "ios", "win"]',{
On 2015/02/27 23:31:02, mtklein wrote:
> If we're going to be building zlib, I'd feel more comfortable if we could use
> our homebrewed version on as many platforms as possible.  Finding bugs on one
> platform will help find bugs elsewhere, and it'll just generally make our
output
> more consistent.
> 
> I'm also okay with landing this as-is and tearing down the Windows-only
> restrictions in a follow-up.

Sounds fine to me. My preference is to land this as is so I can land SkPngCodec,
and then follow up.

[scroggo, 2015-03-02 14:16:20]

The CQ bit was checked by scroggo@google.com

[commit-bot: I haz the power, 2015-03-02 14:18:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/966963002/40001

[commit-bot: I haz the power, 2015-03-02 14:24:20]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/3da9181cd52259102685f3faae68eca5ad1bf773