src/utils/mac/SkCreateCGImageRef.cpp - Issue 966853002: Revert of Revert of replace kIgnore_SkAlphaType with kUnknown_SkAlphaType

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/utils/mac/SkCreateCGImageRef.cpp

Issue 966853002: Revert of Revert of replace kIgnore_SkAlphaType with kUnknown_SkAlphaType (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/utils/mac/SkCreateCGImageRef.cpp

diff --git a/src/utils/mac/SkCreateCGImageRef.cpp b/src/utils/mac/SkCreateCGImageRef.cpp

index 51a5ed9c033d5c6002b8eb44131a4cf98994d114..4675d7185eb6a3813c1d17abef1511a4e9d49ee8 100644

--- a/src/utils/mac/SkCreateCGImageRef.cpp

+++ b/src/utils/mac/SkCreateCGImageRef.cpp

@@ -12,8 +12,9 @@

static CGBitmapInfo ComputeCGAlphaInfo_RGBA(SkAlphaType at) {

CGBitmapInfo info = kCGBitmapByteOrder32Big;

switch (at) {

+ case kUnknown_SkAlphaType:

+ break;

case kOpaque_SkAlphaType:

- case kIgnore_SkAlphaType:

info |= kCGImageAlphaNoneSkipLast;

break;

case kPremul_SkAlphaType:

@@ -29,8 +30,9 @@

static CGBitmapInfo ComputeCGAlphaInfo_BGRA(SkAlphaType at) {

CGBitmapInfo info = kCGBitmapByteOrder32Little;