introduce android_x64 build target

introduce android_x64 build target

BUG=
R=jkummerow@chromium.org

Committed: https://chromium.googlesource.com/v8/v8/+/a5fa093d0bc968c8da2b5f31f44afab207f11ae2

[Weiliang, 2015-02-28 03:07:00]

weiliang.lin@intel.com changed reviewers:
+ danno@chromium.org, jkummerow@chromium.org, verwaest@chromium.org,
yangguo@chromium.org

[Weiliang, 2015-02-28 03:07:01]

PTAL

[Jakob Kummerow, 2015-03-04 11:19:35]

Can you clarify why we need this? Are there any android_x64 devices?

https://codereview.chromium.org/966773005/diff/1/Makefile
File Makefile (right):

https://codereview.chromium.org/966773005/diff/1/Makefile#newcode237
Makefile:237: ANDROID_ARCHES = android_ia32 android_x64 android_arm
android_arm64 android_mipsel android_x87
nit: please use \ to maintain 80-col (like GYPFILES below)

https://codereview.chromium.org/966773005/diff/1/build/android.gypi
File build/android.gypi (right):

https://codereview.chromium.org/966773005/diff/1/build/android.gypi#newcode46
build/android.gypi:46: 'android_lib': '<(android_sysroot)/usr/lib',
doesn't this need to be conditional too?

https://codereview.chromium.org/966773005/diff/1/build/android.gypi#newcode56
build/android.gypi:56: ['target_arch=="x64"', {
doesn't "arm64" need to be included in this list?

https://codereview.chromium.org/966773005/diff/1/tools/testrunner/local/statu...
File tools/testrunner/local/statusfile.py (right):

https://codereview.chromium.org/966773005/diff/1/tools/testrunner/local/statu...
tools/testrunner/local/statusfile.py:57: "android_arm", "android_arm64",
"android_ia32", "android_x87", "android_x64",
nit: 80-col

[Weiliang, 2015-03-05 03:22:36]

Yes, the anroid x64 OS is there and the device should be on the way. 

Thanks
-Weiliang

https://codereview.chromium.org/966773005/diff/1/Makefile
File Makefile (right):

https://codereview.chromium.org/966773005/diff/1/Makefile#newcode237
Makefile:237: ANDROID_ARCHES = android_ia32 android_x64 android_arm
android_arm64 android_mipsel android_x87
On 2015/03/04 11:19:35, Jakob wrote:
> nit: please use \ to maintain 80-col (like GYPFILES below)

Done.

https://codereview.chromium.org/966773005/diff/1/build/android.gypi
File build/android.gypi (right):

https://codereview.chromium.org/966773005/diff/1/build/android.gypi#newcode46
build/android.gypi:46: 'android_lib': '<(android_sysroot)/usr/lib',
On 2015/03/04 11:19:35, Jakob wrote:
> doesn't this need to be conditional too?

Done
Thanks a lot!

https://codereview.chromium.org/966773005/diff/1/build/android.gypi#newcode56
build/android.gypi:56: ['target_arch=="x64"', {
On 2015/03/04 11:19:35, Jakob wrote:
> doesn't "arm64" need to be included in this list?

From android-ndk, arm64 does not need to be included in this list.

https://codereview.chromium.org/966773005/diff/1/tools/testrunner/local/statu...
File tools/testrunner/local/statusfile.py (right):

https://codereview.chromium.org/966773005/diff/1/tools/testrunner/local/statu...
tools/testrunner/local/statusfile.py:57: "android_arm", "android_arm64",
"android_ia32", "android_x87", "android_x64",
On 2015/03/04 11:19:35, Jakob wrote:
> nit: 80-col

Done.

[Jakob Kummerow, 2015-03-05 09:47:46]

lgtm

[Weiliang, 2015-03-06 07:07:51]

On 2015/03/05 09:47:46, Jakob wrote:
> lgtm

Hi Jakob, 
Could you please see the patch set 3? x64 needs to use the linker64. The default
/system/bin/linker causes run-time error:
      /system/bin/sh:  Accessing a corrupted shared library

Thanks
-Weiliang

[Jakob Kummerow, 2015-03-06 08:59:13]

Patch set 3 LGTM.

[commit-bot: I haz the power, 2015-03-09 03:23:19]

Patchset 3 (id:??) landed as
https://crrev.com/a5fa093d0bc968c8da2b5f31f44afab207f11ae2
Cr-Commit-Position: refs/heads/master@{#27055}

[Weiliang, 2015-03-09 03:23:25]

Committed patchset #3 (id:40001) manually as
a5fa093d0bc968c8da2b5f31f44afab207f11ae2.