runtime/vm/flow_graph_type_propagator.cc - Issue 966773002: VM: Better type propagation for string objects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_type_propagator.cc

Issue 966773002: VM: Better type propagation for string objects. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: addressed comment and fixed MaybeNumber Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/flow_graph_type_propagator.cc

===================================================================

--- runtime/vm/flow_graph_type_propagator.cc (revision 44089)

+++ runtime/vm/flow_graph_type_propagator.cc (working copy)

@@ -182,6 +182,12 @@

}

if (!CheckClassInstr::IsImmutableClassId(cid)) {

+ if ((cid == kOneByteStringCid) || (cid == kTwoByteStringCid)) {

+ SetTypeOf(defn, ZoneCompileType::Wrap(CompileType::String()));

+ PropagateRecursive((compare->kind() == Token::kEQ_STRICT) ?

+ branch->true_successor() : branch->false_successor());

+ RollbackTo(rollback_point);

+ }

return;

}

« no previous file with comments | « no previous file | runtime/vm/intermediate_language.cc » ('j') | no next file with comments »