Rewrite plugin_flags.sh Bash script in Python.

tools/clang/scripts/plugin_flags.py

Index: tools/clang/scripts/plugin_flags.py
diff --git a/tools/clang/scripts/plugin_flags.py b/tools/clang/scripts/plugin_flags.py
new file mode 100644
index 0000000000000000000000000000000000000000..390bd3f847daf70fec699e43213b79fb58c32e4d
--- /dev/null
+++ b/tools/clang/scripts/plugin_flags.py
@@ -0,0 +1,35 @@
+#!/usr/bin/env python
+# Copyright 2015 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+# This script returns the flags that should be used when GYP_DEFINES contains
+# clang_use_chrome_plugins. The flags are stored in a script so that they can
+# be changed on the bots without requiring a master restart.
+
+import os
+import sys
+
+# Path constants. (All of these should be absolute paths.)
+THIS_DIR = os.path.abspath(os.path.dirname(__file__))
+CHROMIUM_DIR = os.path.abspath(os.path.join(THIS_DIR, '..', '..', '..'))
+CLANG_LIB_PATH = os.path.join(CHROMIUM_DIR, 'third_party', 'llvm-build',
+                              'Release+Asserts', 'lib')
+
+if sys.platform == 'darwin':
+  LIBSUFFIX = 'dylib'
+else:
+  LIBSUFFIX = 'so'
+
+LIB_PATH = os.path.join(
+    CLANG_LIB_PATH,
+    'libFindBadConstructs' +

[dcheng, 2015/03/03 13:14:44]

Put this all on one line?

+    '.' +
+    LIBSUFFIX)
+
+print ('-Xclang -load -Xclang %s'
+       ' -Xclang -add-plugin -Xclang find-bad-constructs'
+       ' -Xclang -plugin-arg-find-bad-constructs'
+       ' -Xclang check-weak-ptr-factory-order'
+       ' -Xclang -plugin-arg-find-bad-constructs'
+       ' -Xclang strict-virtual-specifiers') % LIB_PATH