Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Issue 966723002: Add [TypeChecking=Interface] to Internals and PrivateScriptTest (Closed)

Created:
5 years, 9 months ago by Jens Widell
Modified:
5 years, 9 months ago
Reviewers:
haraken
CC:
blink-reviews, vivekg, arv+blink, Inactive, vivekg_samsung
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add [TypeChecking=Interface] to Internals and PrivateScriptTest BUG=462561 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191041

Patch Set 1 #

Patch Set 2 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -10 lines) Patch
M Source/core/testing/Internals.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/testing/Internals.cpp View 1 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/testing/Internals.idl View 1 2 chunks +2 lines, -2 lines 1 comment Download
M Source/core/testing/PrivateScriptTest.idl View 2 chunks +3 lines, -2 lines 1 comment Download

Messages

Total messages: 6 (2 generated)
Jens Widell
PTAL https://codereview.chromium.org/966723002/diff/20001/Source/core/testing/Internals.idl File Source/core/testing/Internals.idl (right): https://codereview.chromium.org/966723002/diff/20001/Source/core/testing/Internals.idl#newcode226 Source/core/testing/Internals.idl:226: [RaisesException] void updateLayoutIgnorePendingStylesheetsAndRunPostLayoutTasks(optional Node? node = null); This ...
5 years, 9 months ago (2015-02-27 15:49:51 UTC) #2
haraken
LGTM
5 years, 9 months ago (2015-02-27 15:52:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/966723002/20001
5 years, 9 months ago (2015-02-28 11:05:18 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-02-28 12:23:42 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191041

Powered by Google App Engine
This is Rietveld 408576698