Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 966703003: Add PRESUBMIT tests for _CheckUserActionUpdate function. (Closed)

Created:
5 years, 9 months ago by davileen
Modified:
5 years, 5 months ago
Reviewers:
Paweł Hajdan Jr.
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add PRESUBMIT tests for _CheckUserActionUpdate function. Presubmit does not contain any tests for the _CheckUserActionUpdate function. This commit adds a test to check against an action in actions.xml and one that is not found there. To do this we have to improve the MockInputApi and MockFile classes. BUG=462814 Committed: https://crrev.com/e0426257f867edcef07a156152c61ac01c490dda Cr-Commit-Position: refs/heads/master@{#318759}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -4 lines) Patch
M PRESUBMIT_test.py View 1 chunk +34 lines, -0 lines 0 comments Download
M PRESUBMIT_test_mocks.py View 3 chunks +15 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
davileen
Hi Pawel, Here's a proposed fix for https://code.google.com/p/chromium/issues/detail?id=462814 PTAL, Thanks David
5 years, 9 months ago (2015-02-28 01:35:06 UTC) #2
Paweł Hajdan Jr.
LGTM
5 years, 9 months ago (2015-03-02 19:41:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/966703003/1
5 years, 9 months ago (2015-03-02 19:55:20 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-02 21:10:50 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e0426257f867edcef07a156152c61ac01c490dda Cr-Commit-Position: refs/heads/master@{#318759}
5 years, 9 months ago (2015-03-02 21:12:20 UTC) #7
brucedawson
5 years, 5 months ago (2015-06-29 23:01:17 UTC) #8
Message was sent while issue was closed.
This seems to be causing presubmit failures. See comment on bug.

Powered by Google App Engine
This is Rietveld 408576698