Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 966703002: Updating OTS with new fixes for Color table from github (Closed)

Created:
5 years, 9 months ago by h.joshi
Modified:
5 years, 9 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Updating OTS with new fixes from github OTS has following updates: 1. Update for Color Table parsing which calls user class method getTableAction when parsing color tables 2. Update for debug messages This patch depends on following Blink patch: https://codereview.chromium.org/954953002/ As depricated method "ots::EnableWOFF2();" is removed in Blink patch. Checked on Android, after this and Blink patch combined font (with color table) parsing is working fine. BUG=339857 Committed: https://crrev.com/cac033df33ea0f46328df732394f99a9e63ee885 Cr-Commit-Position: refs/heads/master@{#321298}

Patch Set 1 #

Patch Set 2 : Fixing file permissions #

Unified diffs Side-by-side diffs Delta from patch set Stats (+153 lines, -81 lines) Patch
M third_party/ots/README.chromium View 1 chunk +1 line, -1 line 0 comments Download
M third_party/ots/include/opentype-sanitiser.h View 1 2 chunks +0 lines, -5 lines 0 comments Download
M third_party/ots/src/cmap.cc View 1 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/ots/src/ots.cc View 1 7 chunks +23 lines, -20 lines 0 comments Download
M third_party/ots/src/woff2.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/ots/src/woff2.cc View 1 20 chunks +122 lines, -48 lines 0 comments Download

Messages

Total messages: 20 (7 generated)
behdad_google
lgtm
5 years, 9 months ago (2015-03-03 17:25:44 UTC) #2
h.joshi
Thank you. Once Blink patch is submitted will upload this patch.
5 years, 9 months ago (2015-03-05 06:42:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/966703002/20001
5 years, 9 months ago (2015-03-11 07:56:11 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 9 months ago (2015-03-11 07:56:13 UTC) #7
h.joshi
@jshin: Pls review, Behdad has already reviewed this patch. getting following error. On 2015/03/11 07:56:13, ...
5 years, 9 months ago (2015-03-11 07:58:46 UTC) #9
h.joshi
@jshin: Pls review
5 years, 9 months ago (2015-03-13 02:46:04 UTC) #10
jungshik at Google
On 2015/03/13 02:46:04, h.joshi wrote: > @jshin: Pls review Sorry for the delay. I was ...
5 years, 9 months ago (2015-03-18 20:37:22 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/966703002/20001
5 years, 9 months ago (2015-03-18 20:42:26 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/3244)
5 years, 9 months ago (2015-03-19 00:16:46 UTC) #15
h.joshi
@Jungshik: Thank you
5 years, 9 months ago (2015-03-19 04:21:59 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/966703002/20001
5 years, 9 months ago (2015-03-19 04:22:39 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-19 05:08:11 UTC) #19
commit-bot: I haz the power
5 years, 9 months ago (2015-03-19 05:09:06 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/cac033df33ea0f46328df732394f99a9e63ee885
Cr-Commit-Position: refs/heads/master@{#321298}

Powered by Google App Engine
This is Rietveld 408576698