Issue 966653002: Remove support for thread-based recompilation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 966653002: Remove support for thread-based recompilation (Closed)

Created:
5 years, 10 months ago by jochen (gone - plz use gerrit)

Modified:
5 years, 8 months ago

Reviewers:
Yang

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

More Reviews

Description

Remove support for thread-based recompilation BUG=v8:3608 R=yangguo@chromium.org LOG=y Committed: https://crrev.com/ed5db223a19dfe126af012e894582251aa3635d7 Cr-Commit-Position: refs/heads/master@{#27619}

Patch Set 1 #

Total comments: 1

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+36 lines, -180 lines)			Patch
M	src/cpu-profiler.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/flag-definitions.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	src/isolate.cc	View	1 chunk	+0 lines, -1 line	1 comment	Download
M	src/optimizing-compiler-thread.h	View	8 chunks	+10 lines, -37 lines	0 comments	Download
M	src/optimizing-compiler-thread.cc	View	14 chunks	+25 lines, -138 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

jochen (gone - plz use gerrit)

i'll land this in 4.4 assuming we don't encounter problems until then. ptal

5 years, 10 months ago (2015-02-27 08:35:44 UTC) #1

Yang

lgtm. https://codereview.chromium.org/966653002/diff/1/src/isolate.cc File src/isolate.cc (right): https://codereview.chromium.org/966653002/diff/1/src/isolate.cc#newcode2031 src/isolate.cc:2031: optimizing_compiler_thread_ = new OptimizingCompilerThread(this); Consider renaming OptimizingCompilerThread into ...

5 years, 9 months ago (2015-03-02 07:43:42 UTC) #2

commit-bot: I haz the power

Patchset 1 (id:??) landed as https://crrev.com/ed5db223a19dfe126af012e894582251aa3635d7 Cr-Commit-Position: refs/heads/master@{#27619}

5 years, 8 months ago (2015-04-07 11:00:07 UTC) #3

Yang

5 years, 8 months ago (2015-04-08 09:31:57 UTC) #4

Message was sent while issue was closed.

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1063383004/ by yangguo@chromium.org.

The reason for reverting is: speculative revert due to gc-stress timeouts..

Expand Messages | Collapse Messages