Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 966643002: Add [TypeChecking=Unrestricted] to InternalDictionary (Closed)

Created:
5 years, 9 months ago by Jens Widell
Modified:
5 years, 9 months ago
Reviewers:
haraken
CC:
blink-reviews, vivekg, arv+blink, Inactive, vivekg_samsung
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add [TypeChecking=Unrestricted] to InternalDictionary Also add an unrestricted double member to test both types of doubles. BUG=354298 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191003

Patch Set 1 #

Patch Set 2 : fix test expectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -1 line) Patch
M LayoutTests/fast/dom/idl-dictionary-unittest.html View 5 chunks +11 lines, -0 lines 0 comments Download
M LayoutTests/fast/dom/idl-dictionary-unittest-expected.txt View 1 4 chunks +9 lines, -0 lines 0 comments Download
M Source/core/testing/DictionaryTest.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/testing/DictionaryTest.cpp View 3 chunks +5 lines, -0 lines 0 comments Download
M Source/core/testing/InternalDictionary.idl View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 16 (8 generated)
Jens Widell
PTAL
5 years, 9 months ago (2015-02-27 08:26:29 UTC) #3
Jens Widell
PTAL
5 years, 9 months ago (2015-02-27 08:26:29 UTC) #4
haraken
LGTM
5 years, 9 months ago (2015-02-27 08:27:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/966643002/1
5 years, 9 months ago (2015-02-27 08:32:33 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/49253)
5 years, 9 months ago (2015-02-27 09:46:49 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/966643002/1
5 years, 9 months ago (2015-02-27 11:35:31 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/966643002/20001
5 years, 9 months ago (2015-02-27 13:38:05 UTC) #15
commit-bot: I haz the power
5 years, 9 months ago (2015-02-27 14:50:18 UTC) #16
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191003

Powered by Google App Engine
This is Rietveld 408576698