Issue 96653002: Minor refactoring in FormatBlockCommand::formatRange.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 96653002: Minor refactoring in FormatBlockCommand::formatRange. (Closed)

Created:
7 years ago by arpitab_

Modified:
7 years ago

Reviewers:
tkent, Mike West, ojan

CC:
blink-reviews

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Minor refactoring in FormatBlockCommand::formatRange. Do an early return if root and refNode elements are null. This shall help avoid making some unnecessary calls such as splitTreeToNode and creating range. No new tests are required for this change. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=162891

Patch Set 1 #

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -5 lines)			Patch
	M	Source/core/editing/FormatBlockCommand.cpp	View		1 chunk	+6 lines, -5 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/a.bah@samsung.com/96653002/1

7 years ago (2013-11-29 09:52:43 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/a.bah@samsung.com/96653002/1

7 years ago (2013-11-29 09:53:12 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/a.bah@samsung.com/96653002/1

7 years ago (2013-11-29 09:53:55 UTC) #5

Message was sent while issue was closed.

Change committed as 162891

Expand Messages | Collapse Messages