Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 966463004: Remove unnecessary IndexedDB deps from content/common (Closed)

Created:
5 years, 9 months ago by jsbell
Modified:
5 years, 9 months ago
Reviewers:
jam
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unnecessary IndexedDB deps from content/common These used to be necessary for enums, but those were moved to public/platform/WebIDBTypes.h aeons ago. It looks like content/browser/DEPS was updated but content/common/DEPS was missed. R=jam@chromium.org Committed: https://crrev.com/d4e688f5aab967465b182257983d47276696d3e5 Cr-Commit-Position: refs/heads/master@{#319197}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M content/common/DEPS View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
jsbell
jam@ - please take a look?
5 years, 9 months ago (2015-03-05 00:30:46 UTC) #1
jam
lgtm
5 years, 9 months ago (2015-03-05 01:47:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/966463004/1
5 years, 9 months ago (2015-03-05 02:01:25 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-05 02:39:10 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-05 02:40:09 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d4e688f5aab967465b182257983d47276696d3e5
Cr-Commit-Position: refs/heads/master@{#319197}

Powered by Google App Engine
This is Rietveld 408576698