components/data_reduction_proxy/content/common/data_reduction_proxy_messages.h - Issue 966443002: Add DataReductionProxy IPC to determine if the Data Reduction Proxy was used.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/data_reduction_proxy/content/common/data_reduction_proxy_messages.h

Issue 966443002: Add DataReductionProxy IPC to determine if the Data Reduction Proxy was used. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: bengr CR comments, update OWNERS for IPC messages Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/renderer/page_load_histograms.cc ('K') | « components/data_reduction_proxy/content/common/DEPS ('k') | components/data_reduction_proxy/content/common/data_reduction_proxy_messages.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2015 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 // Multiply-included file, no traditional include guard.

	6 #include "content/public/common/common_param_traits.h"

	7 #include "ipc/ipc_message_macros.h"

	8 #include "net/base/host_port_pair.h"

	9

	10 #define IPC_MESSAGE_START DataReductionProxyStart

	11

	12 IPC_SYNC_MESSAGE_CONTROL1_1(

	13 DataReductionProxyViewHostMsg_IsDataReductionProxy,

	14 net::HostPortPair /* Proxy server */,
	ppi 2015/02/27 10:28:00 by convention, don't capitalize the first word in by convention, don't capitalize the first word in these comments jeremyim 2015/02/27 16:42:53 Done. Show quoted text On 2015/02/27 10:28:00, ppi wrote: > by convention, don't capitalize the first word in these comments Done.
	15 bool /* Proxy server is a Data Reduction Proxy */)
	ppi 2015/02/27 10:28:00 Maybe "True iff the proxy server is ..." so that i Maybe "True iff the proxy server is ..." so that it's clear that you're defining the contract for the bool. jeremyim 2015/02/27 16:42:53 Done. Show quoted text On 2015/02/27 10:28:00, ppi wrote: > Maybe "True iff the proxy server is ..." so that it's clear that you're defining > the contract for the bool. Done.
OLD	NEW