Malformed PortRange or ThirdPartyAuthConfig trigger OnPolicyError.

remoting/base/port_range_unittest.cc

Index: remoting/base/port_range_unittest.cc
diff --git a/remoting/base/port_range_unittest.cc b/remoting/base/port_range_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..7df7cd591192c64fce4c6d69227a91436383517d
--- /dev/null
+++ b/remoting/base/port_range_unittest.cc
@@ -0,0 +1,73 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "remoting/base/port_range.h"
+
+#include <sstream>
+
+#include "testing/gmock/include/gmock/gmock.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace remoting {
+
+TEST(PortRange, ParseEmpty) {
+  PortRange port_range;
+
+  EXPECT_TRUE(PortRange::Parse("", &port_range));
+  EXPECT_TRUE(port_range.is_empty());
+}
+
+TEST(PortRange, ParseValid) {
+  PortRange port_range;
+
+  EXPECT_TRUE(PortRange::Parse("1-65535", &port_range));
+  EXPECT_FALSE(port_range.is_empty());
+  EXPECT_EQ(1u, port_range.min_port);
+  EXPECT_EQ(65535u, port_range.max_port);
+
+  EXPECT_TRUE(PortRange::Parse(" 1 - 65535 ", &port_range));
+  EXPECT_FALSE(port_range.is_empty());
+  EXPECT_EQ(1u, port_range.min_port);
+  EXPECT_EQ(65535u, port_range.max_port);
+
+  EXPECT_TRUE(PortRange::Parse("12400-12400", &port_range));
+  EXPECT_FALSE(port_range.is_empty());
+  EXPECT_EQ(12400u, port_range.min_port);
+  EXPECT_EQ(12400u, port_range.max_port);
+}
+
+TEST(PortRange, ParseInvalid) {
+  PortRange port_range;
+  port_range.min_port = 123;
+  port_range.max_port = 456;
+
+  EXPECT_FALSE(PortRange::Parse("-65535", &port_range));
+  EXPECT_FALSE(PortRange::Parse("1-", &port_range));
+  EXPECT_FALSE(PortRange::Parse("-", &port_range));
+  EXPECT_FALSE(PortRange::Parse("-1-65535", &port_range));
+  EXPECT_FALSE(PortRange::Parse("1--65535", &port_range));
+  EXPECT_FALSE(PortRange::Parse("1-65535-", &port_range));
+  EXPECT_FALSE(PortRange::Parse("0-65535", &port_range));
+  EXPECT_FALSE(PortRange::Parse("1-65536", &port_range));
+  EXPECT_FALSE(PortRange::Parse("1-4294967295", &port_range));
+  EXPECT_FALSE(PortRange::Parse("10-1", &port_range));
+  EXPECT_FALSE(PortRange::Parse("1foo-2bar", &port_range));
+
+  // Unsuccessful parses should NOT modify their output.
+  EXPECT_EQ(123, port_range.min_port);
+  EXPECT_EQ(456, port_range.max_port);
+}
+
+TEST(PortRange, Output) {
+  PortRange port_range;
+  port_range.min_port = 123;
+  port_range.max_port = 456;
+
+  std::ostringstream str;
+  str << port_range;
+
+  EXPECT_THAT(str.str(), testing::MatchesRegex(".*123.*456.*"));
+}
+
+}  // namespace remoting