OLD | NEW |
---|---|
(Empty) | |
1 // Copyright 2015 The Chromium Authors. All rights reserved. | |
2 // Use of this source code is governed by a BSD-style license that can be | |
3 // found in the LICENSE file. | |
4 | |
5 #ifndef REMOTING_BASE_PORT_RANGE_H_ | |
Sergey Ulanov
2015/02/27 03:05:19
does this need to be in /base instead of /protocol
Łukasz Anforowicz
2015/02/27 18:36:12
I can move to "protocol".
| |
6 #define REMOTING_BASE_PORT_RANGE_H_ | |
7 | |
8 #include <ostream> | |
9 #include <string> | |
10 | |
11 #include "base/basictypes.h" | |
12 | |
13 namespace remoting { | |
14 | |
15 // Wrapper for an already parsed value of UdpPortRange policy. | |
16 struct PortRange { | |
Sergey Ulanov
2015/02/27 03:05:19
Please add a constructor to initialize to (0, 0)
Łukasz Anforowicz
2015/02/27 18:36:12
Hmmm. Initially I wanted to respond by saying tha
| |
17 // Both |min_port| and |max_port| are inclusive. | |
18 uint16 min_port; | |
19 uint16 max_port; | |
20 | |
21 inline bool is_empty() const { return (min_port == 0) && (max_port == 0); } | |
Sergey Ulanov
2015/02/27 03:05:19
Maybe call this is_null(), or is_open()?
"empty ra
Łukasz Anforowicz
2015/02/27 18:36:12
Good point. Thanks. I'll also rename ThirdPartyA
| |
22 | |
23 // Parse string in the form "<min_port>-<max_port>". E.g. "12400-12409". | |
24 // Returns true if string was parsed successfuly. | |
25 // | |
26 // Returns false and doesn't modify |out| if parsing fails (i.e. when | |
27 // |port_range| doesn't represent a valid port range). | |
28 static bool Parse(const std::string& port_range, PortRange* out); | |
29 }; | |
30 | |
31 std::ostream& operator<<(std::ostream& os, const PortRange& port_range); | |
32 | |
33 } // namespace remoting | |
34 | |
35 #endif // REMOTING_BASE_PORT_RANGE_H_ | |
OLD | NEW |