Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(634)

Unified Diff: net/test/scoped_mock_log.h

Issue 966423003: Moving ScopedMockLog from net/test to base/test. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@separate-port-range
Patch Set: Limiting the changes to moving ScopedMockLog to base/test Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/test/scoped_mock_log.h
diff --git a/net/test/scoped_mock_log.h b/net/test/scoped_mock_log.h
deleted file mode 100644
index e1edfcccde8cd5150708a792043799b41cc8cc00..0000000000000000000000000000000000000000
--- a/net/test/scoped_mock_log.h
+++ /dev/null
@@ -1,98 +0,0 @@
-// Copyright 2014 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#ifndef NET_QUIC_TEST_TOOLS_SCOPED_MOCK_LOG_H_
-#define NET_QUIC_TEST_TOOLS_SCOPED_MOCK_LOG_H_
-
-#include "base/logging.h"
-#include "testing/gmock/include/gmock/gmock.h"
-#include "testing/gtest/include/gtest/gtest.h"
-
-namespace net {
-namespace test {
-
-// A ScopedMockLog object intercepts LOG() messages issued during its
-// lifespan. Using this together with gMock, it's very easy to test
-// how a piece of code calls LOG(). The typical usage:
-//
-// TEST(FooTest, LogsCorrectly) {
-// ScopedMockLog log;
-//
-// // We expect the WARNING "Something bad!" exactly twice.
-// EXPECT_CALL(log, Log(WARNING, _, "Something bad!"))
-// .Times(2);
-//
-// // We allow foo.cc to call LOG(INFO) any number of times.
-// EXPECT_CALL(log, Log(INFO, HasSubstr("/foo.cc"), _))
-// .Times(AnyNumber());
-//
-// log.StartCapturingLogs(); // Call this after done setting expectations.
-// Foo(); // Exercises the code under test.
-// }
-//
-// CAVEAT: base/logging does not allow a thread to call LOG() again
-// when it's already inside a LOG() call. Doing so will cause a
-// deadlock. Therefore, it's the user's responsibility to not call
-// LOG() in an action triggered by ScopedMockLog::Log(). You may call
-// RAW_LOG() instead.
-class ScopedMockLog {
- public:
- // Creates a ScopedMockLog object that is not capturing logs.
- // If it were to start to capture logs, it could be a problem if
- // some other threads already exist and are logging, as the user
- // hasn't had a chance to set up expectation on this object yet
- // (calling a mock method before setting the expectation is
- // UNDEFINED behavior).
- ScopedMockLog();
-
- // When the object is destructed, it stops intercepting logs.
- ~ScopedMockLog();
-
- // Starts log capturing if the object isn't already doing so.
- // Otherwise crashes. Usually this method is called in the same
- // thread that created this object. It is the user's responsibility
- // to not call this method if another thread may be calling it or
- // StopCapturingLogs() at the same time.
- void StartCapturingLogs();
-
- // Stops log capturing if the object is capturing logs. Otherwise
- // crashes. Usually this method is called in the same thread that
- // created this object. It is the user's responsibility to not call
- // this method if another thread may be calling it or
- // StartCapturingLogs() at the same time.
- void StopCapturingLogs();
-
- // Sets the Log Message Handler that gets passed every log message before
- // it's sent to other log destinations (if any).
- // Returns true to signal that it handled the message and the message
- // should not be sent to other log destinations.
- MOCK_METHOD5(Log, bool(int severity,
- const char* file,
- int line,
- size_t message_start,
- const std::string& str));
-
- private:
- // The currently active scoped mock log.
- static ScopedMockLog* g_instance_;
-
- // Static function which is set as the logging message handler.
- // Called once for each message.
- static bool LogMessageHandler(int severity,
- const char* file,
- int line,
- size_t message_start,
- const std::string& str);
-
- // True if this object is currently capturing logs.
- bool is_capturing_logs_;
-
- // The previous handler to restore when the ScopedMockLog is destroyed.
- logging::LogMessageHandlerFunction previous_handler_;
-};
-
-} // namespace test
-} // namespace net
-
-#endif // NET_QUIC_TEST_TOOLS_SCOPED_MOCK_LOG_H_
« net/test/gtest_util.h ('K') | « net/test/gtest_util.h ('k') | net/test/scoped_mock_log.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698