Moving ScopedMockLog from net/test to base/test.

base/test/scoped_mock_log.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#include "net/test/scoped_mock_log.h"
+#include "base/test/scoped_mock_log.h"
 
-#include "base/logging.h"
-
-namespace net {
-namespace test {
+namespace base {
 
 // static
-ScopedMockLog* ScopedMockLog::g_instance_ = NULL;
+ScopedMockLog* ScopedMockLog::g_instance_ = nullptr;
+Lock ScopedMockLog::g_lock;
 
-ScopedMockLog::ScopedMockLog() : is_capturing_logs_(false) {}
+ScopedMockLog::ScopedMockLog() : is_capturing_logs_(false) {
+}
 
 ScopedMockLog::~ScopedMockLog() {
   if (is_capturing_logs_) {
     StopCapturingLogs();
   }
 }
 
 void ScopedMockLog::StartCapturingLogs() {
+  AutoLock scoped_lock(g_lock);
+
   // We don't use CHECK(), which can generate a new LOG message, and
   // thus can confuse ScopedMockLog objects or other registered
   // LogSinks.
   RAW_CHECK(!is_capturing_logs_);
   RAW_CHECK(!g_instance_);
 
   is_capturing_logs_ = true;
   g_instance_ = this;
   previous_handler_ = logging::GetLogMessageHandler();
   logging::SetLogMessageHandler(LogMessageHandler);
 }
 
 void ScopedMockLog::StopCapturingLogs() {
+  AutoLock scoped_lock(g_lock);
+
   // We don't use CHECK(), which can generate a new LOG message, and
   // thus can confuse ScopedMockLog objects or other registered
   // LogSinks.
   RAW_CHECK(is_capturing_logs_);
   RAW_CHECK(g_instance_ == this);
 
   is_capturing_logs_ = false;
   logging::SetLogMessageHandler(previous_handler_);
-  g_instance_ = NULL;
+  g_instance_ = nullptr;
 }
 
 // static
 bool ScopedMockLog::LogMessageHandler(int severity,
                                       const char* file,
                                       int line,
                                       size_t message_start,
                                       const std::string& str) {
+  // gMock guarantees thread-safety for calling a mocked method
+  // (https://code.google.com/p/googlemock/wiki/CookBook#Using_Google_Mock_and_Threads)
+  // but we also need to make sure that Start/StopCapturingLogs are synchronized
+  // with LogMessageHandler.
+  AutoLock scoped_lock(g_lock);
+
   return g_instance_->Log(severity, file, line, message_start, str);
 }
 
-}  // namespace test
-}  // namespace net
+}  // namespace base