Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(735)

Side by Side Diff: net/quic/congestion_control/rtt_stats_test.cc

Issue 966423003: Moving ScopedMockLog from net/test to base/test. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@separate-port-range
Patch Set: Addressed Ricardo's code review feedback. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/net.gypi ('k') | net/test/gtest_util.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/quic/congestion_control/rtt_stats.h" 5 #include "net/quic/congestion_control/rtt_stats.h"
6 6
7 #include <vector> 7 #include <vector>
8 8
9 #include "base/logging.h" 9 #include "base/logging.h"
10 #include "net/test/scoped_mock_log.h" 10 #include "base/test/mock_log.h"
11 #include "testing/gtest/include/gtest/gtest.h" 11 #include "testing/gtest/include/gtest/gtest.h"
12 12
13 using logging::LOG_WARNING; 13 using logging::LOG_WARNING;
14 using std::vector; 14 using std::vector;
15 using testing::HasSubstr; 15 using testing::HasSubstr;
16 using testing::Message; 16 using testing::Message;
17 using testing::_; 17 using testing::_;
18 18
19 namespace net { 19 namespace net {
20 namespace test { 20 namespace test {
(...skipping 198 matching lines...) Expand 10 before | Expand all | Expand 10 after
219 // Now go back down to 5ms and expire the smoothed metrics, and ensure the 219 // Now go back down to 5ms and expire the smoothed metrics, and ensure the
220 // mean deviation increases to 15ms. 220 // mean deviation increases to 15ms.
221 QuicTime::Delta half_rtt = initial_rtt.Multiply(0.5); 221 QuicTime::Delta half_rtt = initial_rtt.Multiply(0.5);
222 rtt_stats_.UpdateRtt(half_rtt, QuicTime::Delta::Zero(), QuicTime::Zero()); 222 rtt_stats_.UpdateRtt(half_rtt, QuicTime::Delta::Zero(), QuicTime::Zero());
223 EXPECT_GT(doubled_rtt, rtt_stats_.smoothed_rtt()); 223 EXPECT_GT(doubled_rtt, rtt_stats_.smoothed_rtt());
224 EXPECT_LT(initial_rtt, rtt_stats_.mean_deviation()); 224 EXPECT_LT(initial_rtt, rtt_stats_.mean_deviation());
225 } 225 }
226 226
227 TEST_F(RttStatsTest, UpdateRttWithBadSendDeltas) { 227 TEST_F(RttStatsTest, UpdateRttWithBadSendDeltas) {
228 // Make sure we ignore bad RTTs. 228 // Make sure we ignore bad RTTs.
229 ScopedMockLog log; 229 base::test::MockLog log;
230 230
231 QuicTime::Delta initial_rtt = QuicTime::Delta::FromMilliseconds(10); 231 QuicTime::Delta initial_rtt = QuicTime::Delta::FromMilliseconds(10);
232 rtt_stats_.UpdateRtt(initial_rtt, QuicTime::Delta::Zero(), QuicTime::Zero()); 232 rtt_stats_.UpdateRtt(initial_rtt, QuicTime::Delta::Zero(), QuicTime::Zero());
233 EXPECT_EQ(initial_rtt, rtt_stats_.min_rtt()); 233 EXPECT_EQ(initial_rtt, rtt_stats_.min_rtt());
234 EXPECT_EQ(initial_rtt, rtt_stats_.recent_min_rtt()); 234 EXPECT_EQ(initial_rtt, rtt_stats_.recent_min_rtt());
235 EXPECT_EQ(initial_rtt, rtt_stats_.smoothed_rtt()); 235 EXPECT_EQ(initial_rtt, rtt_stats_.smoothed_rtt());
236 236
237 vector<QuicTime::Delta> bad_send_deltas; 237 vector<QuicTime::Delta> bad_send_deltas;
238 bad_send_deltas.push_back(QuicTime::Delta::Zero()); 238 bad_send_deltas.push_back(QuicTime::Delta::Zero());
239 bad_send_deltas.push_back(QuicTime::Delta::Infinite()); 239 bad_send_deltas.push_back(QuicTime::Delta::Infinite());
240 bad_send_deltas.push_back(QuicTime::Delta::FromMicroseconds(-1000)); 240 bad_send_deltas.push_back(QuicTime::Delta::FromMicroseconds(-1000));
241 log.StartCapturingLogs(); 241 log.StartCapturingLogs();
242 242
243 for (QuicTime::Delta bad_send_delta : bad_send_deltas) { 243 for (QuicTime::Delta bad_send_delta : bad_send_deltas) {
244 SCOPED_TRACE(Message() << "bad_send_delta = " 244 SCOPED_TRACE(Message() << "bad_send_delta = "
245 << bad_send_delta.ToMicroseconds()); 245 << bad_send_delta.ToMicroseconds());
246 EXPECT_CALL(log, Log(LOG_WARNING, _, _, _, HasSubstr("Ignoring"))); 246 EXPECT_CALL(log, Log(LOG_WARNING, _, _, _, HasSubstr("Ignoring")));
247 rtt_stats_.UpdateRtt(bad_send_delta, 247 rtt_stats_.UpdateRtt(bad_send_delta,
248 QuicTime::Delta::Zero(), 248 QuicTime::Delta::Zero(),
249 QuicTime::Zero()); 249 QuicTime::Zero());
250 EXPECT_EQ(initial_rtt, rtt_stats_.min_rtt()); 250 EXPECT_EQ(initial_rtt, rtt_stats_.min_rtt());
251 EXPECT_EQ(initial_rtt, rtt_stats_.recent_min_rtt()); 251 EXPECT_EQ(initial_rtt, rtt_stats_.recent_min_rtt());
252 EXPECT_EQ(initial_rtt, rtt_stats_.smoothed_rtt()); 252 EXPECT_EQ(initial_rtt, rtt_stats_.smoothed_rtt());
253 } 253 }
254 } 254 }
255 255
256 } // namespace test 256 } // namespace test
257 } // namespace net 257 } // namespace net
OLDNEW
« no previous file with comments | « net/net.gypi ('k') | net/test/gtest_util.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698