Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Issue 966423002: [turbofan] Fix deferred replacement in simplified lowering. (Closed)

Created:
5 years, 9 months ago by Jarin
Modified:
5 years, 9 months ago
Reviewers:
Benedikt Meurer
CC:
titzer, v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix deferred replacement in simplified lowering. Deferred replacement must also replace in the pending node vector. BUG=chromium:463056 LOG=n R=bmeurer@chromium.org Committed: https://chromium.googlesource.com/v8/v8/+/f0b11873a30cc955ba6d901f87f9eec744dd121f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M src/compiler/simplified-lowering.cc View 1 chunk +5 lines, -0 lines 0 comments Download
A + test/mjsunit/compiler/regress-463056.js View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Jarin
Could you take a look, please?
5 years, 9 months ago (2015-03-02 10:22:19 UTC) #1
Benedikt Meurer
lgtm
5 years, 9 months ago (2015-03-02 10:24:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/966423002/1
5 years, 9 months ago (2015-03-02 10:47:03 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: v8_android_arm_compile_rel on tryserver.v8 (JOB_TIMED_OUT, no build URL) v8_linux64_asan_rel on ...
5 years, 9 months ago (2015-03-02 12:12:05 UTC) #8
Jarin
Committed patchset #1 (id:1) manually as f0b11873a30cc955ba6d901f87f9eec744dd121f (presubmit successful).
5 years, 9 months ago (2015-03-02 12:50:03 UTC) #9
commit-bot: I haz the power
5 years, 9 months ago (2015-03-02 12:50:04 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f0b11873a30cc955ba6d901f87f9eec744dd121f
Cr-Commit-Position: refs/heads/master@{#26938}

Powered by Google App Engine
This is Rietveld 408576698