Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 966363003: Simplify tools/valgrind/locate_valgrind.sh: only allow whitelisted platforms (Closed)

Created:
5 years, 9 months ago by Timur Iskhodzhanov
Modified:
5 years, 9 months ago
Reviewers:
groby-ooo-7-16
CC:
chromium-reviews, glider+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org, Alexander Potapenko
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Simplify tools/valgrind/locate_valgrind.sh: only allow whitelisted platforms TEST=./tools/valgrind/chrome_tests.sh -t cmdline -- echo "hello" Committed: https://crrev.com/e7c0b90a502b596702952dc395b0bf0978f994cd Cr-Commit-Position: refs/heads/master@{#318904}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -23 lines) Patch
M tools/valgrind/locate_valgrind.sh View 1 chunk +15 lines, -23 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Timur Iskhodzhanov
Please review and hit CQ if AOK
5 years, 9 months ago (2015-03-03 13:21:12 UTC) #2
groby-ooo-7-16
lgtm
5 years, 9 months ago (2015-03-03 17:12:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/966363003/1
5 years, 9 months ago (2015-03-03 17:19:30 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-03 17:58:21 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-03 17:59:03 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e7c0b90a502b596702952dc395b0bf0978f994cd
Cr-Commit-Position: refs/heads/master@{#318904}

Powered by Google App Engine
This is Rietveld 408576698