Issue 966333006: tools/gn/example: Fix the usage of HELLO_SHARED_IMPLEMENTATION.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 966333006: tools/gn/example: Fix the usage of HELLO_SHARED_IMPLEMENTATION. (Closed)

Created:
5 years, 9 months ago by tfarina

Modified:
5 years, 9 months ago

Reviewers:
brettw

CC:
chromium-reviews, tfarina, scottmg

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

tools/gn/example: Fix the usage of HELLO_SHARED_IMPLEMENTATION. HELLO_IMPLEMENTATION was a typo in the no-win condition. The correct is to check if HELLO_SHARED_IMPLEMENTATION was defined, as that is what is defined by //tools/gn/example:hello_shared target. BUG=None TBR=brettw@chromium.org Committed: https://crrev.com/81ab611187bf86d20f1cf827fde174ae5719dfb7 Cr-Commit-Position: refs/heads/master@{#318695}

Patch Set 1 #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -8 lines)			Patch
	M	tools/gn/example/hello_shared.h	View		2 chunks	+5 lines, -5 lines	0 comments	Download
	M	tools/gn/example/hello_static.h	View		1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/966333006/1

5 years, 9 months ago (2015-03-02 14:45:21 UTC) #3

commit-bot: I haz the power

Patchset 1 (id:??) landed as https://crrev.com/81ab611187bf86d20f1cf827fde174ae5719dfb7 Cr-Commit-Position: refs/heads/master@{#318695}

5 years, 9 months ago (2015-03-02 15:26:23 UTC) #5

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages