Re-order logic in StartPageService::HotwordEnabled().

Re-order logic in StartPageService::HotwordEnabled().

HotwordServiceFactory::IsServiceAvailable() causes media device
enumeration to start as a side effect. On some platforms, this can block
resulting in a user-visible delay when opening the app list. Although
this probably doesn't affect ChromeOS, it will affect OSX if voice
search and hotwording are enabled on that platform in the future.

This was discovered as a result of investigating crbug.com/458397

Committed: https://crrev.com/d841599fbec3dcfa9028b285ea845303d4704008
Cr-Commit-Position: refs/heads/master@{#318656}

[Anand Mistry (off Chromium), 2015-03-02 01:51:13]

amistry@chromium.org changed reviewers:
+ calamity@chromium.org

[calamity, 2015-03-02 04:20:20]

lgtm

https://codereview.chromium.org/966323002/diff/1/chrome/browser/ui/app_list/s...
File chrome/browser/ui/app_list/start_page_service.cc (right):

https://codereview.chromium.org/966323002/diff/1/chrome/browser/ui/app_list/s...
chrome/browser/ui/app_list/start_page_service.cc:450:
HotwordServiceFactory::IsServiceAvailable(profile_);
Why not service->IsServiceAvailable()?

[Anand Mistry (off Chromium), 2015-03-02 05:43:18]

The CQ bit was checked by amistry@chromium.org

[Anand Mistry (off Chromium), 2015-03-02 05:43:18]

The patchset sent to the CQ was uploaded after l-g-t-m from
calamity@chromium.org
Link to the patchset: https://codereview.chromium.org/966323002/#ps20001 (title:
"Review comment.")

[Anand Mistry (off Chromium), 2015-03-02 05:43:30]

https://codereview.chromium.org/966323002/diff/1/chrome/browser/ui/app_list/s...
File chrome/browser/ui/app_list/start_page_service.cc (right):

https://codereview.chromium.org/966323002/diff/1/chrome/browser/ui/app_list/s...
chrome/browser/ui/app_list/start_page_service.cc:450:
HotwordServiceFactory::IsServiceAvailable(profile_);
On 2015/03/02 04:20:20, calamity wrote:
> Why not service->IsServiceAvailable()?

No reason today. Done.

[commit-bot: I haz the power, 2015-03-02 05:43:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/966323002/20001

[commit-bot: I haz the power, 2015-03-02 06:45:24]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-03-02 06:46:23]

Patchset 2 (id:??) landed as
https://crrev.com/d841599fbec3dcfa9028b285ea845303d4704008
Cr-Commit-Position: refs/heads/master@{#318656}