Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 966293002: Make sure the PDF material toolbar gets hidden after loading. (Closed)

Created:
5 years, 9 months ago by raymes
Modified:
5 years, 9 months ago
Reviewers:
Sam McNally
CC:
chromium-reviews, arv+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make sure the PDF material toolbar gets hidden after loading. Currently the toolbar won't get hidden until after there is some user input. Committed: https://crrev.com/83355348cd9662c5031163270330be75a26ae492 Cr-Commit-Position: refs/heads/master@{#318646}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : #

Total comments: 1

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -3 lines) Patch
M chrome/browser/resources/pdf/pdf.js View 1 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/resources/pdf/ui_manager.js View 1 2 3 2 chunks +10 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
raymes
5 years, 9 months ago (2015-03-02 00:50:48 UTC) #2
Sam McNally
https://codereview.chromium.org/966293002/diff/1/chrome/browser/resources/pdf/pdf.js File chrome/browser/resources/pdf/pdf.js (right): https://codereview.chromium.org/966293002/diff/1/chrome/browser/resources/pdf/pdf.js#newcode440 chrome/browser/resources/pdf/pdf.js:440: this.uiManager_.showUi(); How about setting the initial timeout in the ...
5 years, 9 months ago (2015-03-02 02:01:01 UTC) #3
raymes
https://codereview.chromium.org/966293002/diff/1/chrome/browser/resources/pdf/pdf.js File chrome/browser/resources/pdf/pdf.js (right): https://codereview.chromium.org/966293002/diff/1/chrome/browser/resources/pdf/pdf.js#newcode440 chrome/browser/resources/pdf/pdf.js:440: this.uiManager_.showUi(); On 2015/03/02 02:01:01, Sam McNally wrote: > How ...
5 years, 9 months ago (2015-03-02 02:23:15 UTC) #4
Sam McNally
LGTM https://codereview.chromium.org/966293002/diff/40001/chrome/browser/resources/pdf/ui_manager.js File chrome/browser/resources/pdf/ui_manager.js (right): https://codereview.chromium.org/966293002/diff/40001/chrome/browser/resources/pdf/ui_manager.js#newcode52 chrome/browser/resources/pdf/ui_manager.js:52: * @private Remove.
5 years, 9 months ago (2015-03-02 02:25:39 UTC) #5
raymes
On 2015/03/02 02:25:39, Sam McNally wrote: > LGTM > > https://codereview.chromium.org/966293002/diff/40001/chrome/browser/resources/pdf/ui_manager.js > File chrome/browser/resources/pdf/ui_manager.js (right): ...
5 years, 9 months ago (2015-03-02 02:27:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/966293002/60001
5 years, 9 months ago (2015-03-02 02:28:05 UTC) #9
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 9 months ago (2015-03-02 03:24:55 UTC) #10
commit-bot: I haz the power
5 years, 9 months ago (2015-03-02 03:25:18 UTC) #11
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/83355348cd9662c5031163270330be75a26ae492
Cr-Commit-Position: refs/heads/master@{#318646}

Powered by Google App Engine
This is Rietveld 408576698