Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(490)

Issue 966243002: Reduce platform/heap/ wtf includes. (Closed)

Created:
5 years, 9 months ago by sof
Modified:
5 years, 9 months ago
CC:
blink-reviews, Mads Ager (chromium), oilpan-reviews, blink-reviews-wtf_chromium.org, aandrey+blink_chromium.org, kouhei+heap_chromium.org, Mikhail
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Reduce platform/heap/ wtf includes. Rely on wtf/Forward.h where possible, reducing CPP's #include count ever so slightly when processing platform/heap/Handle.h R= BUG=420515 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191082

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -20 lines) Patch
M Source/platform/heap/Heap.h View 1 chunk +1 line, -3 lines 0 comments Download
M Source/platform/heap/ThreadState.h View 1 chunk +1 line, -3 lines 0 comments Download
M Source/platform/heap/Visitor.h View 3 chunks +3 lines, -14 lines 0 comments Download
M Source/wtf/Forward.h View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
sof
Please take a look. Every little bit helps...hope it's ok not to split out the ...
5 years, 9 months ago (2015-03-02 06:07:09 UTC) #2
tkent
lgtm
5 years, 9 months ago (2015-03-02 06:30:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/966243002/1
5 years, 9 months ago (2015-03-02 06:31:12 UTC) #5
haraken
LGTM
5 years, 9 months ago (2015-03-02 06:33:26 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-02 06:33:55 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191082

Powered by Google App Engine
This is Rietveld 408576698