src/globals.h - Issue 96623002: Use ULL and LL suffix for uint64_t and int64_t constants on Mac

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/globals.h

Issue 96623002: Use ULL and LL suffix for uint64_t and int64_t constants on Mac (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/globals.h

diff --git a/src/globals.h b/src/globals.h

index db80a7e584d33a7d9685c3d2e4fd668599c42f8f..bac8edf4852b72e46f6ea7853726af2f6f9c6d78 100644

--- a/src/globals.h

+++ b/src/globals.h

@@ -187,8 +187,13 @@ typedef byte* Address;

# define V8_INTPTR_C(x) (x ## LL)

# define V8_PTR_PREFIX "I64"

#elif V8_HOST_ARCH_64_BIT

-# define V8_UINT64_C(x) (x ## UL)

-# define V8_INT64_C(x) (x ## L)

+# if defined(__APPLE__) && defined(__MACH__)

Benedikt Meurer 2013/12/02 12:00:06 Please use #if V8_OS_MACOSX instead #if defined(__

haitao.feng 2013/12/02 12:24:46 Done.

+# define V8_UINT64_C(x) (x ## ULL)

+# define V8_INT64_C(x) (x ## LL)

+# else

+# define V8_UINT64_C(x) (x ## UL)

+# define V8_INT64_C(x) (x ## L)

+# endif

# define V8_INTPTR_C(x) (x ## L)

# define V8_PTR_PREFIX "l"

#else

« no previous file with comments | « no previous file | no next file » | no next file with comments »