Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 96623002: Use ULL and LL suffix for uint64_t and int64_t constants on Mac (Closed)

Created:
7 years ago by haitao.feng
Modified:
7 years ago
CC:
v8-dev
Visibility:
Public.

Description

Use ULL and LL suffix for uint64_t and int64_t constants on Mac R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18215

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -5 lines) Patch
M src/globals.h View 1 2 chunks +9 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
haitao.feng
In the /usr/include/stdint.h on Mac, #ifndef _INT64_T #define _INT64_T typedef long long int64_t; #endif /* ...
7 years ago (2013-11-29 09:33:57 UTC) #1
Benedikt Meurer
https://codereview.chromium.org/96623002/diff/1/src/globals.h File src/globals.h (right): https://codereview.chromium.org/96623002/diff/1/src/globals.h#newcode190 src/globals.h:190: # if defined(__APPLE__) && defined(__MACH__) Please use #if V8_OS_MACOSX ...
7 years ago (2013-12-02 12:00:06 UTC) #2
haitao.feng
Thanks for the review. Also modified the other occurrence. https://codereview.chromium.org/96623002/diff/1/src/globals.h File src/globals.h (right): https://codereview.chromium.org/96623002/diff/1/src/globals.h#newcode190 src/globals.h:190: ...
7 years ago (2013-12-02 12:24:46 UTC) #3
Toon Verwaest
lgtm
7 years ago (2013-12-02 15:07:43 UTC) #4
haitao.feng
7 years ago (2013-12-03 02:49:57 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r18215 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698