Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Issue 966223002: Fix a build failing in the x86 linux builds ... (Closed)

Created:
5 years, 9 months ago by Dirk Pranke
Modified:
5 years, 9 months ago
Reviewers:
tfarina, brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix a build failing in the x86 linux builds ... If NaCl is disabled, we get a build failure in the x86 Linux builds when trying to build monacl_shell (which isn't defined). This patch fixes the issue by not trying to include the gn_migration targets *and* by not trying to build monacl_shell when nacl is disabled, both of which were wrong. Also, this patch fixes an issue in 'analyze' where it was trying to analyze build_utf8_validator_tables and not #host. TBR=brettw@chromium.org BUG=462945, 461019 Committed: https://crrev.com/425ba073036f96f04aea09c9836826ccb2e124e4 Cr-Commit-Position: refs/heads/master@{#318626}

Patch Set 1 #

Patch Set 2 : also fix an issue with build_utf8_validator_tables #

Patch Set 3 : fix typo in gyp condition #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M build/all.gyp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M build/gn_migration.gypi View 1 3 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/966223002/1
5 years, 9 months ago (2015-03-01 17:02:08 UTC) #2
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/980)
5 years, 9 months ago (2015-03-01 17:04:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/966223002/20001
5 years, 9 months ago (2015-03-01 17:09:11 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/966223002/40001
5 years, 9 months ago (2015-03-01 17:12:07 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-01 19:07:40 UTC) #12
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/425ba073036f96f04aea09c9836826ccb2e124e4 Cr-Commit-Position: refs/heads/master@{#318626}
5 years, 9 months ago (2015-03-01 19:08:13 UTC) #13
dshwang
still x86 linux is broken Traceback (most recent call last): File "./build/gyp_chromium", line 322, in ...
5 years, 9 months ago (2015-03-01 19:29:45 UTC) #14
Dirk Pranke
5 years, 9 months ago (2015-03-01 19:59:27 UTC) #15
Message was sent while issue was closed.
On 2015/03/01 19:29:45, dshwang wrote:
> still x86 linux is broken

Okay, I will take another look.

Powered by Google App Engine
This is Rietveld 408576698