Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 966213002: Sync the DOM traversal interfaces with the spec (Closed)

Created:
5 years, 9 months ago by philipj_slow
Modified:
5 years, 9 months ago
Reviewers:
Jens Widell
CC:
blink-reviews, blink-reviews-dom_chromium.org, arv+blink, vivekg_samsung, sof, eae+blinkwatch, vivekg, dglazkov+blink, Inactive, rwlbuis
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Sync the DOM traversal interfaces with the spec https://dom.spec.whatwg.org/#traversal There are no changes to the generated code other than ordering. BUG=460722 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191072

Patch Set 1 #

Patch Set 2 : make filter attributes nullable #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -33 lines) Patch
M Source/core/dom/NodeFilter.idl View 1 chunk +23 lines, -19 lines 0 comments Download
M Source/core/dom/NodeIterator.idl View 1 1 chunk +7 lines, -5 lines 0 comments Download
M Source/core/dom/TreeWalker.idl View 1 1 chunk +10 lines, -9 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
philipj_slow
PTAL. Making the filter attributes nullable actually changes the generated code as it requires a ...
5 years, 9 months ago (2015-03-01 16:31:13 UTC) #2
Jens Widell
LGTM On 2015/03/01 16:31:13, philipj_UTC7 wrote: > PTAL. Making the filter attributes nullable actually changes ...
5 years, 9 months ago (2015-03-01 16:52:21 UTC) #3
philipj_slow
On 2015/03/01 16:52:21, Jens Widell wrote: > LGTM > > On 2015/03/01 16:31:13, philipj_UTC7 wrote: ...
5 years, 9 months ago (2015-03-01 16:55:36 UTC) #4
philipj_slow
make filter attributes nullable
5 years, 9 months ago (2015-03-02 00:17:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/966213002/20001
5 years, 9 months ago (2015-03-02 00:48:53 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-02 02:44:37 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191072

Powered by Google App Engine
This is Rietveld 408576698