Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 966173002: Cleanup: Include the associated header file before other includes. (Closed)

Created:
5 years, 9 months ago by tfarina
Modified:
5 years, 9 months ago
Reviewers:
sadrul
CC:
chromium-reviews, danakj, sky
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup: Include the associated header file before other includes. Found by Facebook's flint tool: $ flint ui/gfx/x/x11_error_tracker.cc ui/gfx/x/x11_error_tracker.cc:6: The associated header file of .cpp files should be included before any other includes. Then built with: $ gn gen out-gn $ ninja -C out-gn x BUG=None TEST=see above R=sadrul@chromium.org Committed: https://crrev.com/caba47dad115e69d7f78d15bc3510de6e508eb75 Cr-Commit-Position: refs/heads/master@{#318757}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M ui/gfx/x/x11_error_tracker.cc View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
tfarina
5 years, 9 months ago (2015-03-01 14:52:25 UTC) #1
sadrul
lgtm
5 years, 9 months ago (2015-03-02 16:55:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/966173002/1
5 years, 9 months ago (2015-03-02 19:40:06 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-02 21:09:36 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-02 21:10:43 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/caba47dad115e69d7f78d15bc3510de6e508eb75
Cr-Commit-Position: refs/heads/master@{#318757}

Powered by Google App Engine
This is Rietveld 408576698