Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 965963002: Roll buildtools from 93b32d0 -> d4dd4f79 to get a new GN build. (Closed)

Created:
5 years, 9 months ago by Dirk Pranke
Modified:
5 years, 9 months ago
Reviewers:
brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll buildtools from 93b32d0 -> d4dd4f79 to get a new GN build. This picks up: Roll the GN binaries to #318791. Roll the GN binaries from 317120:318791 (from git 74add9fc39 to 3d7a60db). This fixes 'gn clean' and picks up some new features for introspections (see #317159). TBR=brettw@chromium.org BUG=430215 Committed: https://crrev.com/162dd1a3d5b634a988884a290eaaa5d8a31c6a71 Cr-Commit-Position: refs/heads/master@{#318952}

Patch Set 1 #

Patch Set 2 : merge to #318764 #

Patch Set 3 : merge to #318791 #

Patch Set 4 : Roll buildtools from 93b32d0 -> dcbaef to get a new GN build. #

Patch Set 5 : fix buildtools_revision #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M DEPS View 1 2 3 4 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Dirk Pranke
5 years, 9 months ago (2015-03-03 20:59:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/965963002/60001
5 years, 9 months ago (2015-03-03 21:00:33 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: android_aosp on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/builds/64097) android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 9 months ago (2015-03-03 21:05:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/965963002/80001
5 years, 9 months ago (2015-03-03 21:16:24 UTC) #7
brettw
lgtm
5 years, 9 months ago (2015-03-03 22:58:10 UTC) #8
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 9 months ago (2015-03-03 23:05:46 UTC) #9
commit-bot: I haz the power
5 years, 9 months ago (2015-03-03 23:06:21 UTC) #10
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/162dd1a3d5b634a988884a290eaaa5d8a31c6a71
Cr-Commit-Position: refs/heads/master@{#318952}

Powered by Google App Engine
This is Rietveld 408576698