Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Unified Diff: tools/perf/benchmarks/gpu_times.py

Issue 965953002: [Telemetry] Output all timeline based metrics on all timeline interaction records (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address Sami's comment Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/telemetry/telemetry/web_perf/timeline_based_measurement.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/benchmarks/gpu_times.py
diff --git a/tools/perf/benchmarks/gpu_times.py b/tools/perf/benchmarks/gpu_times.py
index c2ccd0ec7f90f024a6dccdd7e1ff377db381c702..246f3c18fbb81b4a88f1403b26cd8804427f6197 100644
--- a/tools/perf/benchmarks/gpu_times.py
+++ b/tools/perf/benchmarks/gpu_times.py
@@ -13,18 +13,13 @@ TOPLEVEL_CATEGORIES = ['disabled-by-default-gpu.device',
'disabled-by-default-gpu.service']
-def _GetGPUTimelineMetric(_):
- return [gpu_timeline.GPUTimelineMetric()]
-
-
class _GPUTimes(benchmark.Benchmark):
def CreateTimelineBasedMeasurementOptions(self):
cat_string = ','.join(TOPLEVEL_CATEGORIES)
cat_filter = tracing_category_filter.TracingCategoryFilter(cat_string)
return timeline_based_measurement.Options(
- overhead_level=cat_filter,
- get_metrics_from_flags_callback=_GetGPUTimelineMetric)
+ overhead_level=cat_filter)
@classmethod
def ValueCanBeAddedPredicate(cls, value):
« no previous file with comments | « no previous file | tools/telemetry/telemetry/web_perf/timeline_based_measurement.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698